122369 - [XBLFC] Select multiples with size == options.length should not have scrollbars

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

Linux 2002012821 -

If you have a select multiple with a size of 5 and 5 options, a scrollbar will
appear.  As soon as you click on the scrollbar, it dissapears and the document
reflows.  Testcase coming up.

0. Enable XBL form controls
1. View the testcase
2. Click on any scrollbar in the selects.

Actual: scrollbars are visible and dissapear on click

Expected: the scrollbars shouldn't even be there to begin with as there is
nothing to scroll.  The scrollbars indicate wrongly there are more options to
scroll through.

Note: a select multiple of size 2 gets this correctly, all other sizes are
incorrect.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: testcase

Comment 2

[Brian Ryner (not reading)]

-> 1.0, nominating for beta1.

Comment 3

[Peter Trudelle]

ADT triage team needs info: How common is this on top sites, and what is the
worst case scenario when it happens?

Comment 4

[Brian Ryner (not reading)]

Not sure how common this is, I know it happens in Bugzilla though.

Worst case scenario when this happens is that the user tries to scroll down,
only to find that the scrollbar disappears, causing the listbox to shrink and
other items on the page to shift around.  I'd recommend + on this one.

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 129790 has been marked as a duplicate of this bug. ***

Comment 6

[John Morrison]

*** Bug 129071 has been marked as a duplicate of this bug. ***

Comment 7

[David Hyatt]

--> me

Comment 8

[David Hyatt]

Attachment: mPageCount should just match desiredRows...

Comment 9

[Brian Ryner (not reading)]

Comment on attachment 73658 [details] [diff] [review]
mPageCount should just match desiredRows...

r=bryner

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 73658 [details] [diff] [review]
mPageCount should just match desiredRows...

sr=[e-mail]

Comment 11

[David Hyatt]

Fixed.

Comment 12

[Brendan Eich [:brendan]]

I was asked to sr, so I'll pick a nit: don't add spaces on an empty line:

-
+  
   AddBorderAndPadding(aSize);

/be

Comment 13

[Boris Zbarsky [:bzbarsky]]

Bug 130308 filed on us still leaving space for the scrollbar though we do not
paint it.

Comment 14

[Peter Trudelle]

nsbeta1+ per Nav triage team, in case it gets reopened.

Comment 15

[:deanis74]

verified using the testcase and the bugzilla query page.