1223877 - [MarionetteJS] Make the screenshot on timeout take whole screen not just current app

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

Recently I noticed that if you are doing a waitFor inside of an app frame, and it times out, the screenshot it will give you back is from the app and not the system. This is misleading since the system may be showing a dialog or some other kind of overlay, but it won't show up in the screenshot. I think the fix should be simple.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia PR]

Gareth, can you help me out here?

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Can we confirm that this fixes the issue by grabbing one of the snapshots?

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Just as an update here. I pushed two PRs that ran a test with a timeout with the context being the homescreen. Oddly, when I ran this test locally I got the wierd Homescreen only screenshot. But in automation I was seeing the full system app for both with [1] and without [2] this fix. I will need to investigate why the "half" screenshot happens, especially in automation.

1.) https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b457776e6ba5
2.) https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=362ff072ce80

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Ok, I think I found the problem. I use the same PR and force pushed too soon, so I think my changes overwrote it. In any case, I used two different PRs and was able to prove the different.

Screenshot failure without patch:
https://public-artifacts.taskcluster.net/ALbFzLNPRTOQl_7IyuMJbw/0/public/logs/live_backing.log

Screenshot failure with patch:
https://public-artifacts.taskcluster.net/HuS-DnjnQNijRIri4bJxOw/0/public/logs/live_backing.log

Notice how in the second log, we get a screenshot which shows system app chrome. Gareth, I think this is ready for your review.

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8686159 [details] [review]
[Gaia PR]

Nice one!

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

landed on master https://github.com/mozilla-b2g/gaia/commit/ea673b5c4cc19c3daca072691a659c68e4c6937f