Closed
Bug 1224228
Opened 9 years ago
Closed 9 years ago
Firefox for iOS: download button displays empty overlay for locales that don't have newsletter
Categories
(www.mozilla.org :: Pages & Content, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: flod, Assigned: agibson)
Details
(Whiteboard: [kb=1895036])
Attachments
(2 files)
iPod screenshot
I open www.mozilla.org/firefox/ios with my iPod from Italy, tap the download button but I only get a dark overlay with a close button.
|
Assignee | |
Comment 1•9 years ago
|
||
It's not iOS specific, but locale specific: https://www.mozilla.org/it/firefox/ios/ Will investigate!
|
Reporter | |
Comment 2•9 years ago
|
||
It works with newsletter locales (tried de, fr, es-ES, pl), fails with others (tried cs, it, zh-TW).
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → agibson
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
Summary: Firefox for iOS: download button displays empty overlay → Firefox for iOS: download button displays empty overlay for locales that have newsletter
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [kb=1895036]
|
||
Comment 3•9 years ago
|
||
For those who want to click on the "get it now/download now" link from their mobile device, lets makes sure that it takes them straight to the app store - no need for an overlay/send to device since they are already on mobile.
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to mhan@mozilla.com from comment #3) > For those who want to click on the "get it now/download now" link from their > mobile device, lets makes sure that it takes them straight to the app store > - no need for an overlay/send to device since they are already on mobile. Agreed - not quite sure why we're not doing this here already
|
|
Assignee | |
Comment 5•9 years ago
|
||
|
|
Reporter | |
Updated•9 years ago
|
Summary: Firefox for iOS: download button displays empty overlay for locales that have newsletter → Firefox for iOS: download button displays empty overlay for locales that don't have newsletter
|
||
Comment 6•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/77a0da770e8e0d52cdc34dd9516006306622fd4c [fix bug 1224228] Show App Store badge for non-newsletter locales and iOS users https://github.com/mozilla/bedrock/commit/549b9ac01b648fb83fe45336e2670bbe18ac64c0 Merge pull request #3553 from alexgibson/bug-1224228-firefox-ios-blank-overlay [fix bug 1224228] Show App Store badge for non-newsletter locales and iOS users
|
|
||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•9 years ago
|
||
Fixed on prod: https://www.mozilla.org/it/firefox/ios/
You need to log in
before you can comment on or make changes to this bug.
Description
•