1225019 - Disable Intel VPx hardware decoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Chris Peterson [:cpeterson]]

The Intel VPx hardware decoder has some buggy drivers and can actually be slower than the ffvp9 software decoder.

Comment 1

[Chris Peterson [:cpeterson]]

[Tracking Requested - why for this release]:

We should disable Intel VPx hardware decoder (enabled in bug 1101885) in FF 44 because it can cause crashes.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Disable intel hardware VP decoder by default.

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 8690596 [details] [diff] [review]
Disable intel hardware VP decoder by default.

Review of attachment 8690596 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. We will need to uplift this fix to Aurora 44.

::: modules/libpref/init/all.js
@@ +341,5 @@
>  pref("media.opus.enabled", true);
>  #ifdef MOZ_WAVE
>  pref("media.wave.enabled", true);
>  #endif
>  #ifdef MOZ_WEBM

btw, why do we need #ifdef MOZ_WEBM? Do we ever build Firefox without WebM support?

Comment 4

[Jean-Yves Avenard [:jya]]

I think that this is now unused.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87c224b71033

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/87c224b71033

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Jean-yves, should we consider uplifting this to Aurora44?

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked as disabling this will improve FF44 stability.

Comment 9

[Jean-Yves Avenard [:jya]]

yes it should be.

Comment 10

[Jean-Yves Avenard [:jya]]

Comment on attachment 8690596 [details] [diff] [review]
Disable intel hardware VP decoder by default.

Approval Request Comment
[Feature/regressing bug #]:1225019
[User impact if declined]: Computers needing reboot, decoding error
[Describe test coverage new/current, TreeHerder]: In central, there can't be regressions caused by the commit, it's just disabling a new code.
[Risks and why]: None
[String/UUID change made/needed]: None

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8690596 [details] [diff] [review]
Disable intel hardware VP decoder by default.

It seems to be me this decoder is not ready to be used by default and therefore being pref'd off for 44. Taking it.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b17fbacc5377

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b17fbacc5377