1225641 - Change default security flags within NetUtil.newChannel()

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Christoph Kerschbaumer [:ckerschb]]

Since we are about to start converting callsites within JS to use asyncOpen2() instead of asyncOpen() it's time to change the default within NetUtil.newChannel(). Such a change involves updating the assertions within ::AsyncOpen() as well.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1225641_change_default_securityflag_netutil.patch

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Jonas, ever seen such a compile error for OS X 10.7 opt (also Mulet) [1]? Are we end up mixing Object C and C++? Any suggestions on how to fix? Potentially we could use nsScriptSecurityManager::IsSystemPrincipal() instead of nsContentUtils::IsSystemPrincipal() for OS X.


INFO -  /builds/slave/try-m64-0000000000000000000000/build/src/image/decoders/icon/mac/nsIconChannelCocoa.mm:270:3: error: unexpected '@' in program
INFO -    NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT;
INFO -    ^
INFO -  ../../../../dist/include/nsObjCExceptions.h:218:48: note: expanded from macro 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT'
INFO -  #define NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT @try {
INFO -                                                 ^
INFO -  1 error generated.
INFO -  make[6]: *** [nsIconChannelCocoa.o] Error 1
INFO -  make[5]: *** [image/decoders/icon/mac/target] Error 2


[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf56a85e726a

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I have no idea how that specific compile error happens. But sure, try calling nsIScriptSecurityManager.IsSystemPrincipal

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Christoph Kerschbaumer [:ckerschb] from comment #2)
> INFO - 
> /builds/slave/try-m64-0000000000000000000000/build/src/image/decoders/icon/
> mac/nsIconChannelCocoa.mm:270:3: error: unexpected '@' in program

.mm files are Objective-C++, which is C++ combined with the Objective-C extensions to C, so that @ shouldn't be unexpected.  I notice that nsIconChannelCocoa.mm includes nsObjCExceptions.h, which #undef's "try" and "catch"; maybe the #include order matters?

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Jed Davis [:jld] from comment #4)
> (In reply to Christoph Kerschbaumer [:ckerschb] from comment #2)
> > INFO - 
> > /builds/slave/try-m64-0000000000000000000000/build/src/image/decoders/icon/
> > mac/nsIconChannelCocoa.mm:270:3: error: unexpected '@' in program
> 
> .mm files are Objective-C++, which is C++ combined with the Objective-C
> extensions to C, so that @ shouldn't be unexpected.  I notice that
> nsIconChannelCocoa.mm includes nsObjCExceptions.h, which #undef's "try" and
> "catch"; maybe the #include order matters?

Thanks Jed, order of inclusions really matters here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=93f95f1606a6

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7e775b3742d9

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7e775b3742d9