1225939 - Crash in Client: HistoryPanel.(tableView(HistoryPanel) -> (UITableView, editActionsForRowAtIndexPath : NSIndexPath)

Status: RESOLVED INACTIVE

(Firefox for iOS :: Home screen, defect)

Description

[Aaron Train [:aaronmt]]

Last Exception Backtrace:
0   CoreFoundation                	0x255bf676 __exceptionPreprocess + 122 (NSException.m:162)
1   libobjc.A.dylib               	0x3693ae12 objc_exception_throw + 34 (objc-exception.mm:531)
2   CoreFoundation                	0x255bf54c +[NSException raise:format:arguments:] + 100 (NSException.m:131)
3   Foundation                    	0x2634cbc4 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 88 (NSException.m:152)
4   UIKit                         	0x2989f9cc -[UITableView _endCellAnimationsWithContext:] + 10420 (UITableView.m:1720)
5   Client                        	0x2d632c HistoryPanel.(tableView(HistoryPanel) -> (UITableView, editActionsForRowAtIndexPath : NSIndexPath) -> [AnyObject]?).(closure #1).(closure #1).(closure #1) + 3816 (HistoryPanel.swift:419)
6   Shared                        	0x98cc08 thunk + 16 (DeferredUtils.swift:0)
7   Shared                        	0x9c3b60 partial apply for thunk + 76 (Deferred.swift:0)
8   Shared                        	0x9c38a4 partial apply for thunk + 52 (Deferred.swift:0)
9   Shared                        	0x9c395c partial apply for Deferred.((_fill in _64863D17A065AD747F9AFBDCF9C2ED6A)<A> (Deferred<A>) -> (A, assertIfFilled : Bool) -> ()).(closure #2) + 124 (Deferred.swift:44)
10  libdispatch.dylib             	0x3705fbe6 _dispatch_call_block_and_release + 6 (init.c:757)
11  libdispatch.dylib             	0x3705fbd2 _dispatch_client_callout + 18 (init.c:817)
12  libdispatch.dylib             	0x3706df6c _dispatch_main_queue_callback_4CF$VARIANT$mp + 1520 (inline_internal.h:1063)
13  CoreFoundation                	0x25582968 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 4 (CFRunLoop.c:1612)
14  CoreFoundation                	0x25580e62 __CFRunLoopRun + 1570 (CFRunLoop.c:2718)
15  CoreFoundation                	0x254d4114 CFRunLoopRunSpecific + 516 (CFRunLoop.c:2814)
16  CoreFoundation                	0x254d3f00 CFRunLoopRunInMode + 104 (CFRunLoop.c:2844)
17  GraphicsServices              	0x2e68aac4 GSEventRunModal + 156 (GSEvent.c:2245)
18  UIKit                         	0x29716f10 UIApplicationMain + 140 (UIApplication.m:3665)
19  Client                        	0x126718 main + 368 (main.swift:22)
20  libdyld.dylib                 	0x370a986e tlv_get_addr + 42 (threadLocalHelpers.s:310)

Comment 1

[Emily Toop (:fluffyemily)]

Aaron, have you managed to find an STR for this? I am trying but I can delete history rows till I'm blue in the face and can't get it to crash.

Comment 2

[Aaron Train [:aaronmt]]

Same here, not sure

Comment 3

[Richard Newman [:rnewman]]

Have you tried deleting the last item in a section, or the last item total?

Perhaps while syncing?

Comment 4

[Aaron Train [:aaronmt]]

Yes, neither yield a crash.

Comment 5

[Aaron Train [:aaronmt]]

Number 1 currently on 1.3

Comment 6

[Aaron Train [:aaronmt]]

Currently #3 on 2.0

Comment 7

[Richard Newman [:rnewman]]

I just fixed something very similar to this for bookmarks. Might be worth seeing if it applies here, too. 

https://github.com/mozilla/firefox-ios/commit/0e9f374344ad2a2d3941b63ea74913e01712a145

Comment 8

[Aaron Train [:aaronmt]]

This is still showing up on 5.3 (and reports include iOS 10)

Comment 9

[Catalin Suciu [:csuciu]]

This crash is showing up in the organizer under App Store for 6.0 Beta 7

Comment 10

[Aaron Train [:aaronmt]]

Continues to show up under 6.0 live