1226178 - Fix deprecated octal literals warnings in Telemetry tests

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P4)

Description

[Alessio Placitelli [:Dexter]]

In the log output from test_TelemetryLockCount.js and test_TelemetryLateWrites.js xpcshell tests we can spot the following warning:

LOG: Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: octal literals and octal escape sequences are deprecated" {file: "c:/mozilla-central/obj-i686-pc-mingw32/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetryLockCount.js" line: 15 column: 17 source: "const RW_OWNER = 0600;
"}]"

It can be reproduced by running the tests as follows:

./mach xpcshell-test toolkit/components/telemetry/tests/unit/test_TelemetryLateWrites.js

and 

./mach xpcshell-test toolkit/components/telemetry/tests/unit/test_TelemetryLockCount.js

We can fix it by changing [0] and [1] to:

const RW_OWNER = parseInt("0600", 8);

To check that this fixes the warning, run the tests again and check that the warning is no longer reported.

[0] - https://dxr.mozilla.org/mozilla-central/rev/a2f83cbe53ac4009afa4cb2b0b8f549289b23eeb/toolkit/components/telemetry/tests/unit/test_TelemetryLateWrites.js#12
[1] - https://dxr.mozilla.org/mozilla-central/rev/a2f83cbe53ac4009afa4cb2b0b8f549289b23eeb/toolkit/components/telemetry/tests/unit/test_TelemetryLockCount.js#15

Comment 1

[Georg Fritzsche [:gfritzsche]]

Chaitanya, would you be interested in working on this bug?

Comment 2

[chaithanya]

(In reply to Georg Fritzsche [:gfritzsche] from comment #1)
> Chaitanya, would you be interested in working on this bug?

Yes, I would like to work on this bug.

Comment 3

[Georg Fritzsche [:gfritzsche]]

Great, assigning it to you.
Let us know if you run into any problems here.

Comment 4

[chaithanya]

Attachment: Made nesessary changes to avoid the warning.Please let me know if any further changes are to be made.

Comment 5

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8690019 [details] [diff] [review]
Made nesessary changes to avoid the warning.Please let me know if any further changes are to be made.

Review of attachment 8690019 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this looks good! Can you update the patch with the reviewer information?
(i.e. add r=<reviewer>, "Bug 1226178 - Fix deprecated octal literals warnings in Telemetry tests. r=gfritzsche")

Comment 6

[chaithanya]

Attachment: Added r=<reviewer> as by comment 5 .

Comment 7

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8690024 [details] [diff] [review]
Added r=<reviewer> as by  comment 5 .

Review of attachment 8690024 [details] [diff] [review]:
-----------------------------------------------------------------

This should be r=gfritzsche, also please remove the " around the message.

Comment 8

[chaithanya]

Attachment: Made changes as per Comment 7

Comment 9

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8690026 [details] [diff] [review]
Made  changes as per Comment 7

Review of attachment 8690026 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, lets get this landed!

Comment 10

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

nit: ES6 allows to define octals as 0o600

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2316f6179102

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2316f6179102