Closed Bug 1226601 Opened 9 years ago Closed 9 years ago

fix extract_db

Categories

(Input :: General, defect)

Product:
Input
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

When I copied over extract_db and updated it for Fjord, I missed that it's building messages with context and needs to use pgettext.

The output is currently:

# l10n: This is a product name
_lazy("""Firefox""", 'DB: feedback.Product.display_name')


That should be:

# l10n: This is a product name
pgettext("""DB: feedback.Product.display_name""", """Firefox""")


This should get fixed soon.
Grabbing it to fix today.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
So, two things:

1. This should have been using pgettext.

2. On Input we have different requirements regarding strings translation where we need all the strings in the feedback app to be translated, so it's better to break up all the db strings into app-specific sets.

3. I should have filed a followup bug for bug #1001430 to check localization progress and then update the feedback templates to use the newly translated strings, but didn't. I'll do that after finishing up this work.
Landed in https://github.com/mozilla/fjord/commit/31c16070e098abec190c5c1cff4c73d1e30e9bc7

This only affects development and doesn't affect our production servers. I extracted and synced strings. I'm going to mark this FIXED.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.