1226706 - [META] add-on / loop-test status tracking bug

Status: RESOLVED INCOMPLETE

(Hello (Loop) :: Client, defect, P2)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Here's a place for the folks working on the Hello systems-addon and the loop-test (and soon loop) github repos can post updates and status.  It is intended to replace the private email thread so that the rest of the team can better follow what's going on.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

I've imported the latest stuff from the PR branch, done a quick fixup, and the tests on loop-test/build are passing again.  The add-on no-longer works, because the chrome.manifests are now gone from mozilla-central and the ones in loop-test are outdated.  Up next is removing those from loop-test, and writing a python script that uses the mozbuild PyPi package in a venv to run generate the chrome.manifests as described at https://ci.mozilla.org/job/mozilla-central-docs/Tree_Documentation/build/buildsystem/jar-manifests.html

Comment 2

[Mark Banner (:standard8)]

Adding bugs for the system-addon, the status for that will be tracked in those bugs.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

On loop-test, I've updated from-system.sh on master with code that copies over the chrome.manifest file and merged that to build, along with an up-to-date chrome.manifest.

The add-on on build still doesn't run because the prefs file is missing.  I've also tweaked from-system.sh to get the prefs stuff copied on master, and pushed that to github.  I haven't yet rebased build against those changes on master, but that shouldn't be hard, and may be enough to get the add-on running in one of the PR builds again.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Mark and I paired on updating the github plans here, and https://public.etherpad-mozilla.org/p/nov-3-hello-planning reflects what we're hoping to get done this week and during Orlando, as well as after that.  Current tasks: Mark is looking at Selenium for driving unit tests on Travis, and I am going to dig into making the build-system use real dependencies and/or nodemon so that we can have an automated watch system that updates things when they change.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

I've created a nodemon branch in mozilla/loop-test, and forked/simplifed the run-server.sh from pageshot, so watching works to a first approximation.  I've switched all the "cp" commands to "rsync" so that we can easily excluding files from the copy.  (Eventually I suspect we'll stop copying directories wholesale entirely, but there's some more work before that can happen.

The build takes a built less than six seconds, but the vast majority of that time is building the jsx -> js files, so up next is adding a dependency rule so that only changed jsx files get built, and then figuring out what other dependency rules and exclusions we want, and how much of those are important to have now.

"make runserver" now simply shells out to bin/run-server.sh, which does a build before invoking the server.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

I've rebased and merged the nodemon branch into build.

Comment 7

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.