Closed
Bug 1227188
Opened 9 years ago
Closed 9 years ago
Autophone - use new browser start logcat message to determine start time
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
9.75 KB,
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/integration/mozilla-inbound/rev/db9e19d4bbb9 provides a means of determining when Fennec has started. We should begin using this on trunk and fall back to the older methods if it is not found.
Assignee | ||
Comment 2•9 years ago
|
||
The current message appears after Throbber start so it isn't useful. See bug 1214810 comment 5
Assignee | ||
Comment 3•9 years ago
|
||
Adds support for the new Fennec application start message. This will increase the detected start time leading to a apparent improvement in Throbber start, stop which is solely due to this change in measurement. Note, I also included a fix for detecting Start proc on Android 5.1 where the pid and user are included in the Start proc message. Example: Start proc 3682:org.mozilla.fennec_bclary/u0a54 for activity org.mozilla.fennec_bclary/org.mozilla.gecko.webapp.Dispatcher
Attachment #8699602 -
Flags: review?(gbrown)
Comment 4•9 years ago
|
||
Comment on attachment 8699602 [details] [diff] [review] bug-1227188-v1.patch Review of attachment 8699602 [details] [diff] [review]: ----------------------------------------------------------------- ::: tests/s1s2test.py @@ +283,5 @@ > (logcat_prefix, throbber_prefix)) > re_throbber_stop_time = re.compile('%s %s stop' % > (logcat_prefix, throbber_prefix)) > + self.loggerdeco.debug( > + 'analyze_logcat: re_start_time: %s' % re_start_time.pattern) This seems like a low-value thing to log.
Attachment #8699602 -
Flags: review?(gbrown) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Ok. removed the low value log messages. https://github.com/mozilla/autophone/commit/90a7885549f32facffd6bb2829c679dc534dd5c2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•