1227304 - communitybox and topicboxes macros producing invalid code

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: Macros/Templates, defect)

Description

[Stephanie Hobson [:shobson]]

For some reason the communitybox and topicboxes macros are producing a list of items where the first child is a <a> instead of a <li>. The problem is more likely to be in the DiscussionList template but I had a look and could not figure out what's going on :(

Example of invalid code:
<ul class="communitymailinglist">
  <a href="https://lists.mozilla.org/listinfo/dev-mdc" class="external external-icon">Mailing list</a> 
  <li><a href="http://groups.google.com/group/mozilla.dev.mdc" class="external external-icon">Google Group</a></li> 
  <li><a href="http://groups.google.com/group/mozilla.dev.mdc/feeds" class="external external-icon">RSS feed</a></li> 
</ul>

Test page:
https://developer.mozilla.org/en-US/docs/User%3Astephaniehobson%3Acommunitybox

This bug is visible because the space between the <a> has less space between it and all the <li>s.

Comment 1

[Janet Swisher]

Fixed this in https://developer.mozilla.org/en-US/docs/Template:DiscussionList (used by both of the other templates), where the "<ul" tag was not getting a closing ">", and was therefore stealing it from the first "<li>".

Comment 2

[Stephanie Hobson [:shobson]]

Awesome, thanks :)