1227316 - [MERGE] per bug queries are to be removed and simple page created for a users to see their old tags

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[David Lawrence [:dkl]]

SSIA

Comment 1

[David Lawrence [:dkl]]

Actually thinking about his before moving forward, I need to clarify that this may in fact going against what we planned. During my merge work, I got over greedy and removed too much I think.

Glob, you mentioned that you would like for personal tags to be removed from the merge with upstream trunk. Along they way per bug queries (what you see in the footer) transitioned into what is now Personal Tags (what is the in bug attributes) in upstream trunk. Do we want to keep the per bug queries in the footer like we have now and just not do the full transition to Personal Tags? Or did you mean when you said that we want to get rid of all it altogether? 

Gathering a little data to back up our decision, it doesn't seem like the per bug queries we have in the footer are heavily used and may not be missed: 150 distinct owners with 385 tags spread across 6877 bugs.

dkl

Comment 2

[:glob ✱]

(In reply to David Lawrence [:dkl] from comment #1)
> Glob, you mentioned that you would like for personal tags to be removed from
> the merge with upstream trunk. Along they way per bug queries (what you see
> in the footer) transitioned into what is now Personal Tags (what is the in
> bug attributes) in upstream trunk. Do we want to keep the per bug queries in
> the footer like we have now and just not do the full transition to Personal
> Tags? Or did you mean when you said that we want to get rid of all it
> altogether?

remove bug tagging completely; it's a high complexity feature with minimal uptake on bmo that has solid work-arounds (eg. browser bookmarks with tags).

in order to ease migration for those currently using it, we should keep the data in the database (in its current form) with a simple page that lists your saved tags with a link to show the bug list.  it shouldn't be possible to add/edit those tags anymore, and we should remove that page and the db entries after a decent grace period.

the page should have simple help which describes alternatives, and we'd probably need an option to open each bug in its own tab (so they can be individually bookmarked/browser-tagged).

Comment 3

[David Lawrence [:dkl]]

Attachment: 1227316_1.patch

Add new table to Saved Searches tab under userprefs.cgi that lists the current old bug tags for the user. They can run the query or remove the tag if desired. There will be no way to add *new* tags as they are obsolete.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8691552 [details] [diff] [review]
1227316_1.patch

Review of attachment 8691552 [details] [diff] [review]:
-----------------------------------------------------------------

r- this seems to have bitrotted? My fault, I'm sorry. :(

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8691552 [details] [diff] [review]
1227316_1.patch

(In reply to Dylan William Hardison [:dylan] from comment #4)
> Comment on attachment 8691552 [details] [diff] [review]
> 1227316_1.patch
> 
> Review of attachment 8691552 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r- this seems to have bitrotted? My fault, I'm sorry. :(

I have merged the upstream-merge branch to both current origin/master and upstream/master. Make sure you are checking out that branch when doing your review.

dkl

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8691552 [details] [diff] [review]
1227316_1.patch

Review of attachment 8691552 [details] [diff] [review]:
-----------------------------------------------------------------

I somehow missed that the review was against the "upstream-merge" branch, woops :-)

It looks good but test 10 fails:

t/010dependencies.t .. 1/? 
#   Failed test 'Dependency on Bugzilla::Sentry from Bugzilla::Error causes loop. --ERROR'
#   at t/010dependencies.t line 93.

#   Failed test 'Dependency on Bugzilla::Util from Bugzilla::Sentry causes loop. --ERROR'
#   at t/010dependencies.t line 93.

#   Failed test 'Dependency on Bugzilla::Error from Bugzilla::Util causes loop. --ERROR'
#   at t/010dependencies.t line 93.
# Looks like you failed 3 tests of 1179.

Comment 7

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8691552 [details] [diff] [review]
1227316_1.patch

Review of attachment 8691552 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, I take that back. the patch does not cause that failure so I see no reason to not r+ as it does work.
Cheers!

r=dylan

Comment 8

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   e6280b2..b855b21  upstream-merge -> upstream-merge