1227526 - No survey displayed when clicking on 'Leave feedback' button at the end of the first call

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Ada [:adalucinet]]

Reproducible with latest Nightly 45.0a1 (from 2015-11-23)
Affected platforms: Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.5

Steps to reproduce:
1. Launch Nightly with a clean profile.
2. Create a conversation. 
3. Copy link and join the conversation from PC2 or different Firefox profile.
3. End conversation on PC1.
4. Click on 'Leave Feedback' button.

Expected results: A new tab with a survey is opened.
Actual results: Conversation windows is closed. No survey displayed.

Additional notes:
1. Browser console output:
'Loop:Loop hawkRequest error: Object { code: 400, errno: 203, error: "Unable to leave a room you have not…" }' thrown by MozLoopService.jsm:708
'Loop:Object { code: 400, errno: 203, error: "Unable to leave a room you have not…" }' thrown by LoopRooms.jsm:826
 
2. Regression range:
Last good revision: eb3016abd37db2e6a6d923265047e84b12c0af61 (2015-11-18)
First bad revision: a523d4c7efe2f43dd6b25a176c07b729918d550f (2015-11-19)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=eb3016abd37db2e6a6d923265047e84b12c0af61&tochange=a523d4c7efe2f43dd6b25a176c07b729918d550f

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: Wait for the feedback page to be opened, before closing the window

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8691378 [details] [diff] [review]
Patch v1: Wait for the feedback page to be opened, before closing the window

Review of attachment 8691378 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a bit puzzled as to why the tests don't need an update? The stubs don't seem to be returning values. openURLStub is a stub, but its not defined to return a promise, so I don't see how the close function is being called.

Comment 3

[Mike de Boer [:mikedeboer]]

(In reply to Mark Banner (:standard8) from comment #2)
> I'm a bit puzzled as to why the tests don't need an update? The stubs don't
> seem to be returning values. openURLStub is a stub, but its not defined to
> return a promise, so I don't see how the close function is being called.

As long as they're stubbed, even though the return value is 'undefined', the fact it's evaluated means success and the synchronous thenable is resolved without error.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8691378 [details] [diff] [review]
Patch v1: Wait for the feedback page to be opened, before closing the window

Review of attachment 8691378 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, thanks for the explanation. r=Standard8

Comment 5

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/integration/fx-team/rev/e84368c1f7b7c61f28f60365b64a70fdf3465c08
Bug 1227526: Wait for the feedback page to be opened, before closing the window. r=Standard8

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e84368c1f7b7

Comment 7

[Ada [:adalucinet]]

Verified fixed with latest Nightly 45.0a1 (from 2015-12-03), across platforms [1].

[1] Windows 8.1 64-bit, Mac OS X 10.11 and Ubuntu 14.04 32-bit