1227686 - Pull to sync row shows content behind it

Status: RESOLVED INVALID

(Firefox for iOS :: Home screen, defect)

Description

[Darrin Henein [:darrin]]

As seen in History, likely visible in other panels as well.

That view should have a solid background or we should clip the underlying table view.

Comment 1

[Darrin Henein [:darrin]]

Attachment: 2015-11-21+10.42.56.png

Comment 2

[Bryan Munar (:bkmunar)]

LOL hello again

Comment 3

[Bryan Munar (:bkmunar)]

Attachment: PR - tryna get Darrin's approval first

Comment 4

[Bryan Munar (:bkmunar)]

oops, wrong bug i closed hehe

Comment 5

[Darrin Henein [:darrin]]

Comment on attachment 8704251 [details] [review]
PR - tryna get Darrin's approval first

Not exactly what I had in mind, I dont think it should come in front of the table view. See Mail.app and the refresh behavior it has... refresh view should come from behind the table, and disappear behind it (and in fact, collapse) when the user scrolls back up.

Comment 7

[Bunn [:bunn]]

I'm guessing this was already fixed on another bug/task? From what I see the UI looks fairly different from the reported screenshot.
Also, I see the comment on GitHub: (https://github.com/mozilla-mobile/firefox-ios/pull/1401)
"@bkmunar I believe this has been resolved as part of the panel clean up work you did. Is that correct? If so, feel free to close this."

It looks to me that we can close this ticket and GitHub PR as well.

Comment 8

[Bunn [:bunn]]

Attachment: Trying to reproduce the issue.

Comment 9

[Stephan Leroux [:sleroux]]

> I'm guessing this was already fixed on another bug/task? From what I see the UI looks fairly different from the reported screenshot.

This bug was for a section that now lives under the 'Synced Tabs' button instead of being a top level panel. I'm pretty sure this issue is no longer valid. Thanks for checking in and closing the PR!

Comment 10

[Bunn [:bunn]]

Stephan, the Github PR is still open ( https://github.com/mozilla-mobile/firefox-ios/pull/1401 ) I can't close it :)

Comment 11

[Stephan Leroux [:sleroux]]

My apologies - I've gone ahead and closed it.