1227722 - Disabling the crash reporter no longer works.

Status: NEW

(Toolkit :: Crash Reporting, defect)

Description

[Mike Kaply [:mkaply]]

In the past, you could do something like this:

Cc["@mozilla.org/toolkit/crash-reporter;1"].
          getService(Ci.nsICrashReporter).enabled = false;

to disable the crash reporter. This is no longer working.

If you alert .enabled after setting it to false, it's still true.

Comment 1

[Mike Kaply [:mkaply]]

Looks like it regressed here:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b2486721572e&tochange=2ab07dec6404

Comment 2

[Mike Kaply [:mkaply]]

Looks like:

https://bugzilla.mozilla.org/show_bug.cgi?id=842728

Comment 3

[Mike Kaply [:mkaply]]

Apparently this was removed on purpose.

Only way to turn off the crash reporter is:

MOZ_CRASHREPORTER_DISABLE=1

Comment 4

[YUKI "Piro" Hiroshi]

This problem still exist on Firefox 45ESR and Nightly 49.0a1.

Comment 5

[YUKI "Piro" Hiroshi]

Steps to reproduce:

1. Disable crash reporter by various method.
2. Open Scratchpad and run following scripts in the Browser context.
----------------------------------------------
(function(){
Components.utils.import('resource://gre/modules/ctypes.jsm');
var library = ctypes.open(ctypes.libraryName('nss3'));
var PR_Free = library.declare(
  'PR_Free',
  ctypes.default_abi,
  ctypes.void_t,
  ctypes.voidptr_t
);
var ptr = new ctypes.voidptr_t(1);
PR_Free(ptr);
})();
----------------------------------------------

Actual result:
The crash reporter appears.

Expected result:
The crash is not handled by the crash reporter provided by Firefox itself.


All following methods to disable crash reporter did not work:

 * Unchecking "Advanced" => "Data Choices" => "Enable Crash Reporter"
 * Setting "SubmitCrashReport" (DWORD) to "0" in:
   - "HKEY_LOCAL_MACHINE\Software\Mozilla\Firefox\Crash Reporter"
   - "HKEY_LOCAL_MACHINE\Software\Wow6432Node\Mozilla\Firefox\Crash Reporter"
   - "HKEY_CURRENT_USER\Software\Mozilla\Firefox\Crash Reporter"
   - "HKEY_CURRENT_USER\Software\Wow6432Node\Mozilla\Firefox\Crash Reporter"

Comment 6

[YUKI "Piro" Hiroshi]

Or, should the checkbox be removed from the option page?

Comment 7

[YUKI "Piro" Hiroshi]

In eu-US locale, the checkbox says: "Enable Crash Reporter: Firefox submits crash reports to help Mozilla make your browser more stable and secure"
However, actually it does not enable/disable the crash reporter itself and the "submit" checkbox in the crash reporter, on Windows.
The checkbox completely does nothing anymore.

Comment 8

[Mike Kaply [:mkaply]]

Ted's on vacation right now, but I think he is the right person to help us figure this out.

At the bare minimum, the wording of the checkbox needs to be changed, because it doesn't turn the crash reporter on and off.