1228111 - First suggestion doesn't match the action when I'm searching for [space][keyword][space][search term]

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[arni2033]

Attachment: screenshot 1 - First suggestion is wrong when I'm searching for [space][keyword][space][search term].png

>>>   My Info:   Win7_64, Nightly 45, 32bit, ID 20151125030231
STR:
1. Open about:preferences#search , set keyword "bng" for Bing
2. Type " bng test" in urlbar
3. Press Enter.

Result:       
 After Step 2 the first suggestion says "test - Search with Bing"
 After Step 3 browser opens a page with Yahoo! search results for " bng test"

Expectations: 
 I agree with what happens after Step 3, because this hack looks like the only way to search for
 some text that starts with a keyword. And I expect the first suggestion to be
 "bng test - Search with [default engine]"
 However, if the plan is to allow user search for "bng test" if Shift is pressed, then I'm not sure
 about how expected is result of Step 3. Anyway, results after Steps 2 and 3 do not match each other

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

yeah, this is a bug.
We can either ignore the space and run a keyword query, or run a search.

Honestly I think a prefix space like that one followed by a keyword leaves no doubts the user wanted to use the keyword but mistakenly typed a space, so we should just ignore the space.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

This is now WFM, I'll just add a test.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1228111 - Tests that keywords in Address Bar can be prefixed by spaces.

Review commit: https://reviewboard.mozilla.org/r/213896/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213896/

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I suspect it was fixed when we made navigation respect what is in the Address Bar, rather than guessing.

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 8943548 [details]
Bug 1228111 - Tests that keywords in Address Bar can be prefixed by spaces.

https://reviewboard.mozilla.org/r/213896/#review219890

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cf4c4fc0763
Tests that keywords in Address Bar can be prefixed by spaces. r=adw

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2cf4c4fc0763

Comment 8

[Sajedul Islam]

I have reproduced this bug with Nightly 45.0a1 (2015-11-25) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Beta !

Build   ID    20180215111455
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

Comment 9

[Anca Soncutean, Desktop QA]

This bug is fixed on the latest Nightly 60.0a1 (2018-02-19)  under Windows 10 x64, macOS 10.13 and Ubuntu 16.04 x64.  Based on my testing and the one described in comment 8, I will mark this bug as verified fixed.