1228340 - Get rid of the js_ prefix under jit/

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

The following patches get rid of the js_ prefix for most remaining things present under jit/. All the allocators operators remain unaffected, as I don't have a good idea / plan for a name (e.g. instead of js_malloc, maybe malloc_? or _malloc?).

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 1.ionoptimizationslevel.patch

js_IonOptimizationLevel => IonOptimizationLevel

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 2.jitoptions.patch

Rename the js_JitOptions struct to DefaultJitOptions, and get rid of the js_ prefix for the JitOptions singleton instance.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 3.codespecname.patch

Get rid of the js_ prefix for Code{Spec,Name}.

Comment 4

[Hannes Verschore [:h4writer]]

Comment on attachment 8692538 [details] [diff] [review]
1.ionoptimizationslevel.patch

Review of attachment 8692538 [details] [diff] [review]:
-----------------------------------------------------------------

Patch seems fine.
I'm only not sure if 'singletons' should start with capital. In the old code, I just copied the JitOptions case, which was js_JitOptions at the time.
Now removing the js_ makes this a capital. Should we lowercase this?
@Waldo: do you have an idea about this?

Comment 5

[Hannes Verschore [:h4writer]]

Comment on attachment 8692540 [details] [diff] [review]
2.jitoptions.patch

Review of attachment 8692540 [details] [diff] [review]:
-----------------------------------------------------------------

Same comment as with IonOptimizationLevel

Comment 6

[Jeff Walden [:Waldo]]

Comment on attachment 8692538 [details] [diff] [review]
1.ionoptimizationslevel.patch

Review of attachment 8692538 [details] [diff] [review]:
-----------------------------------------------------------------

I think our convention is to use a leading capital letter for globally-scoped variables, so JitOptions would be right.  That said, I'm not a big fan of it, and I'd rather we had class-scoped variables with lowercase names, wherever it makes sense to do so.  But that's out of scope for a pure renaming patch/bug, IMO.

::: js/src/jit/IonOptimizationLevels.cpp
@@ +15,5 @@
>  
>  namespace js {
>  namespace jit {
>  
> +OptimizationInfos IonOptimizations;

"Info" usually isn't plural, it's a collective noun, so this likely should be OptimizationInfo.  But a separate thing, not this bug.

Comment 7

[Jason Orendorff [:jorendorff]]

Comment on attachment 8692541 [details] [diff] [review]
3.codespecname.patch

Review of attachment 8692541 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Interpreter.cpp
@@ +1957,5 @@
>      JS_END_MACRO
>  
>  #define TRY_BRANCH_AFTER_COND(cond,spdec)                                     \
>      JS_BEGIN_MACRO                                                            \
> +        MOZ_ASSERT(CodeSpec[*REGS.pc].length == 1);                        \

Micro-nit: Please re-align the \ at the end of this line.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dd50837b1f0c
https://hg.mozilla.org/integration/mozilla-inbound/rev/91bfd1093c2c
https://hg.mozilla.org/integration/mozilla-inbound/rev/526a9c02295b

Comment 9

[Benjamin Bouvier [:bbouvier] (inactive)]

Thank you all for the quick reviews! Bug 1229338 addresses the renaming of OptimizationInfos.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dd50837b1f0c
https://hg.mozilla.org/mozilla-central/rev/91bfd1093c2c
https://hg.mozilla.org/mozilla-central/rev/526a9c02295b