1228359 - Experiment add-ons can no more use a chrome.manifest

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Marco Bonardo [:mak]]

experiments should ideally work like bootstrapped add-ons, differences may really hurt productivity (I spent time today trying to figure why my manifest was being ignored)

Comment 1

[Marco Bonardo [:mak]]

[Tracking Requested - why for this release]: There may be experiments hitting this in the wild, and I'm working on a new one.

Comment 2

[Dave Townsend [:mossop]]

This was an accidental change from bug 1193926. The fix is simple but we should get a testcase for this too.

Comment 3

[Dave Townsend [:mossop]]

Attachment: MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Bug 1228359: Allow experiments to register chrome.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26291/diff/1-2/

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

https://reviewboard.mozilla.org/r/26291/#review23745

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9aa64c29bccc

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Approval Request Comment
[Feature/regressing bug #]: Bug 1193926
[User impact if declined]: Experiments will be a little harder to write than normal. We might have broken existing experiment code.
[Describe test coverage new/current, TreeHerder]: About to land, the fix is dead simple though
[Risks and why]: No risks
[String/UUID change made/needed]: None

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for Windows XPCshell bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=247bfa7ed091

Failure: https://treeherder.mozilla.org/logviewer.html#?job_id=17897155&repo=mozilla-inbound

TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_bootstrap.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_bootstrap.js | AddonListener.onOperationCancelled - [AddonListener.onOperationCancelled : 1357] "onOperationCancelled" == "onInstalled"
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_bootstrap.js | InstallListener.onInstallFailed - [InstallListener.onInstallFailed : 1419] "onInstallFailed" == "onInstallEnded"
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_experiment.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_experiment.js | test_checkCompatibility - [test_checkCompatibility : 1574] 4 == 3
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_mapURIToAddonID.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_mapURIToAddonID.js | run_test_7 - NS_ERROR_FILE_ACCESS_DENIED: Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]
TEST-UNEXPECTED-FAIL | all-test-dirs.list:toolkit/mozapps/extensions/test/xpcshell/test_temporary.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | all-test-dirs.list:toolkit/mozapps/extensions/test/xpcshell/test_system_update.js | xpcshell return code: 0

13:24:50     INFO -  TEST-PASS | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_bootstrap.js | observe - [observe : 223] true == true
13:24:50     INFO -  PROCESS | 11472 | 1448573090451	addons.xpi	ERROR	Failed to create directory c:\\users\\cltbld\\appdata\\local\\temp\\xpc-profile-pfbqbi\\extensions\\[e-mail]: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: SIO_installDirectory :: line 422"  data: no] Stack trace: SIO_installDirectory()@resource://gre/modules/addons/XPIProvider.jsm:422 < SIO_installDirEntry()@resource://gre/modules/addons/XPIProvider.jsm:486 < SIO_move()@resource://gre/modules/addons/XPIProvider.jsm:509 < DirInstallLocation_installAddon()@resource://gre/modules/addons/XPIProvider.jsm:7601 < AI_startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:5949 < TaskImpl_run()@resource://gre/modules/Task.jsm:330 < Handler.prototype.process()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934 < this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813
13:24:50     INFO -  PROCESS | 11472 | 1448573090452	addons.xpi	ERROR	Failure moving c:\\users\\cltbld\\appdata\\local\\temp\\xpc-profile-pfbqbi\\extensions\\staged\\[e-mail] to c:\\users\\cltbld\\appdata\\local\\temp\\xpc-profile-pfbqbi\\extensions
13:24:50     INFO -  PROCESS | 11472 | 1448573090453	addons.xpi	WARN	Failed to install C:\\slave\\test\\build\\tests\\xpcshell\\tests\\toolkit\\mozapps\\extensions\\test\\xpcshell\\addons\\test_bootstrap1_2.xpi from file:///C:/slave/test/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/addons/test_bootstrap1_2.xpi: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: SIO_rollback :: line 572"  data: no] Stack trace: SIO_rollback()@resource://gre/modules/addons/XPIProvider.jsm:572 < SIO_move()@resource://gre/modules/addons/XPIProvider.jsm:512 < DirInstallLocation_installAddon()@resource://gre/modules/addons/XPIProvider.jsm:7601 < AI_startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:5949 < TaskImpl_run()@resource://gre/modules/Task.jsm:330 < Handler.prototype.process()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934 < this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813
13:24:50     INFO -  PROCESS | 11472 | 1448573090454	addons.xpi	WARN	removeActiveInstall: could not find active install for file:///C:/slave/test/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/addons/test_bootstrap1_2.xpi
13:24:50     INFO -  "Got onOperationCancelled event for [e-mail]"
13:24:50  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell-unpack.ini:toolkit/mozapps/extensions/test/xpcshell/test_bootstrap.js | AddonListener.onOperationCancelled - [AddonListener.onOperationCancelled : 1357] "onOperationCancelled" == "onInstalled"

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26291/diff/2-3/

Comment 10

[Dave Townsend [:mossop]]

Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

For some reason retaining references to nsIFiles in the tests was causing file locking issues on windows. That seems odd but we don't have to retain those references so this is the simple fix.

Comment 11

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

https://reviewboard.mozilla.org/r/26291/#review23813

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a5ad0e73b4bf

Comment 13

[Dave Townsend [:mossop]]

Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Approval Request Comment: See comment 7

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a5ad0e73b4bf

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Important to keep experiments working, please uplift to aurora and beta

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e576dd92d0f2

This has conflicts on beta that'll need to be resolved.

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Mossop will try to fix this up for beta 9, which goes to build thursday morning.

Comment 18

[Dave Townsend [:mossop]]

Comment on attachment 8692624 [details]
MozReview Request: Bug 1228359: Allow experiments to register chrome. r?felipe

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26291/diff/3-4/

Comment 19

[Dave Townsend [:mossop]]

Attachment: beta patch

Comment 20

[Dave Townsend [:mossop]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2ce1209499f8

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e576dd92d0f2

Comment 22

[Liz Henry (:lizzard) (relman/hg->git project)]

Adding tracking flag since this was a regression - just in case it reopens.