1228463 - pixman.h: No such file or directory with --enable-system-pixman

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Karl Tomlinson (:karlt)]

make[1]: Entering directory '/mnt/sda11/karl/obj/media/webrtc/signaling/signaling_ecc'
AudioConduit.o
c++ -o AudioConduit.o -c  -I../../../../dist/system_wrappers -include /mnt/ssd1/karl/moz/dev/config/gcc_hidden.h -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -D_ISOC99_SOURCE=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DLOG4CXX_STATIC -D_NO_LOG4CXX -DUSE_SSLEAY -D_CPR_USE_EXTERNAL_LOGGER -DWEBRTC_RELATIVE_PATH -DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_UINT8_T=1 -DHAVE_UINT16_T=1 -DHAVE_UINT32_T=1 -DHAVE_UINT64_T=1 -DMOZILLA_INTERNAL_API -DOS_LINUX -DSIP_OS_LINUX -DWEBRTC_POSIX -D_GNU_SOURCE -DLINUX -DGIPS_VER=3510 -DSECLIB_OPENSSL -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/mnt/ssd1/karl/moz/dev/media/webrtc/signaling -I. -I/mnt/ssd1/karl/moz/dev/media/webrtc -I/mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src -I/mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src/common -I/mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src/common/browser_logging -I/mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src/common/time_profiling -I/mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src/media -I/mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src/media-conduit -I/mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src/mediapipeline -I/mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src/peerconnection -I/mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src/sdp/sipcc -I/mnt/ssd1/karl/moz/dev/dom/base -I/mnt/ssd1/karl/moz/dev/dom/media -I/mnt/ssd1/karl/moz/dev/media/mtransport -I/mnt/ssd1/karl/moz/dev/media/webrtc/trunk -I/mnt/ssd1/karl/moz/dev/media/libyuv/include -I/mnt/ssd1/karl/moz/dev/media/mtransport/third_party/nrappkit/src/util/libekr -I/mnt/ssd1/karl/moz/dev/netwerk/srtp/src/include -I/mnt/ssd1/karl/moz/dev/netwerk/srtp/src/crypto/include -I../../../../ipc/ipdl/_ipdlheaders -I/mnt/ssd1/karl/moz/dev/ipc/chromium/src -I/mnt/ssd1/karl/moz/dev/ipc/glue -I../../../../dist/include    -fPIC  -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -MD -MP -MF .deps/AudioConduit.o.pp  -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -gsplit-dwarf -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe  -DDEBUG -DTRACING -g -fno-omit-frame-pointer   -I/mnt/sda11/karl/obj/dist/include/nspr -I/usr/include/nss '-I/usr/include/pixman-1 '   /mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src/media-conduit/AudioConduit.cpp
In file included from ../../../../dist/include/nsRegion.h:29:0,
                 from ../../../../dist/include/mozilla/layers/LayersTypes.h:20,
                 from ../../../../dist/include/ImageContainer.h:18,
                 from /mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src/media-conduit/MediaConduitInterface.h:16,
                 from /mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src/media-conduit/AudioConduit.h:13,
                 from /mnt/ssd1/karl/moz/dev/media/webrtc/signaling/src/media-conduit/AudioConduit.cpp:14:
../../../../dist/system_wrappers/pixman.h:3:25: fatal error: pixman.h: No such file or directory
 #include_next <pixman.h>
                         ^
compilation terminated.
/mnt/ssd1/karl/moz/dev/config/rules.mk:956: recipe for target 'AudioConduit.o' failed
make[1]: *** [AudioConduit.o] Error 1
make[1]: Leaving directory '/mnt/sda11/karl/obj/media/webrtc/signaling/signaling_ecc'
/mnt/ssd1/karl/moz/dev/config/rules.mk:547: recipe for target 'default' failed
make: *** [default] Error 2

Comment 1

[Karl Tomlinson (:karlt)]

Regression from https://hg.mozilla.org/mozilla-central/rev/f8a04f388bf1

Is there a correct way to pass pkg-config strings, which have spaces between args, from .gyp files?

https://hg.mozilla.org/mozilla-central/annotate/c321d84038519dcf1670d59fd2c5c00ad8a85a55/media/webrtc/signaling/signaling.gyp#l204

Comment 2

[Mike Hommey [:glandium]]

Try replacing AC_SUBST(MOZ_PIXMAN_CFLAGS) with AC_SUBST_LIST(MOZ_PIXMAN_CFLAGS) in configure.in.

Comment 3

[Mike Hommey [:glandium]]

(If that works, I have a better fix)

Comment 4

[Karl Tomlinson (:karlt)]

(In reply to Mike Hommey [:glandium] from comment #2)
> Try replacing AC_SUBST(MOZ_PIXMAN_CFLAGS) with
> AC_SUBST_LIST(MOZ_PIXMAN_CFLAGS) in configure.in.

That works, thanks :)

Comment 5

[Mike Hommey [:glandium]]

Attachment: Set MOZ_PIXMAN_{CFLAGS,LIBS} directly from PKG_CHECK_MODULES

Comment 6

[Mike Hommey [:glandium]]

Just in case, can you double check this still works for you? :)

Comment 7

[Karl Tomlinson (:karlt)]

Yes, that still works, and simplifies things nicely, thanks.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d951ff1e2699

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d951ff1e2699