122851 - View source channel should impl nsIUploadChannel if it impls nsIHttpChannel

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Boris Zbarsky [:bzbarsky]]

If we try to send postdata with a viewsource channel we crash in
nsDocShell::DoURILoad because of the following:

nsCOMPtr<nsIUploadChannel> uploadChannel(do_QueryInterface(httpChannel));
NS_ASSERTION(uploadChannel, "http must support nsIUploadChannel");

// we really need to have a content type associated with this stream!!
uploadChannel->SetUploadStream(aPostData,nsnull, -1);

We trigger the assertion, of course.  :)

Nothing posts to view source channels yet, but eventually we will (once all
those pesky view source bugs are fixed).

Patch coming up.

Comment 1

[Darin Fisher]

cc'ing rpotts... his nsIWebPageDescriptor solution may make all of this unnecessary.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: More interface hackery

Attaching patch just in case.  If rpotts' solution allows us to rip all this
interface hackery out of the view source channel, so much the better.  If not,
we'll likely need this.

Comment 3

[rpotts (gone)]

Comment on attachment 67306 [details] [diff] [review]
More interface hackery

r/sr=[e-mail]

This looks good to me...  cause we'll need view-source channels to look 'just
like http channels' if we end up forcing a reload from the server ...

Comment 4

[Darin Fisher]

Comment on attachment 67306 [details] [diff] [review]
More interface hackery

r/sr=darin too then

Comment 5

[Boris Zbarsky [:bzbarsky]]

Checked in, then.  Thanks for the reviews!