1228529 - [Meta] Get the last stable version of the Hello beta add-on downloaded and installed automatically

Status: RESOLVED INVALID

(Hello (Loop) :: Client, defect, P1)

Comment 1

[Sevaan Franks [:sevaan]]

Attachment: Hello Update State Panels

Comment 2

[Romain Testard [:RT]]

Attachment: Hello Update State Panels v2.png

Same as Sevaan's previous version without the 3rd view with is not necessary given there does not need to be UX to support the scenario where the add-on auto updates.

Comment 3

[David Critchley (:dcritch)]

Was pointed to WebIDE by the devtools team, which appears to have the functionality we are looking for. Looking at the code, we likely want to copy how the WebIDE manages the ADB Helper (xpi) addon.

https://dxr.mozilla.org/mozilla-central/source/devtools/client/webide

The WebIDE utilizes the AddonManager:
https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/AddonManager.jsm
to install and manage the ADBHelper addon
https://dxr.mozilla.org/mozilla-central/source/devtools/client/webide/modules/addons.js

It, also, appears from the code, that using the AddonManager requires "chrome" privileges, lines 5,7 in addons.js

Here's the install and uninstall function snippets from addons.js:
install: function() {
    AddonManager.getAddonByID(this.addonID, (addon) => {
      if (addon && !addon.userDisabled) {
        this.status = "installed";
        return;
      }
      this.status = "preparing";
      if (addon && addon.userDisabled) {
        addon.userDisabled = false;
      } else {
        AddonManager.getInstallForURL(this.xpiLink, (install) => {
          install.addListener(this);
          install.install();
        }, "application/x-xpinstall");
      }
    });
  },

  uninstall: function() {
    AddonManager.getAddonByID(this.addonID, (addon) => {
      addon.uninstall();
    });
  }

Likely will need more input from someone more familiar with the browser side of things.

Comment 4

[David Critchley (:dcritch)]

Attachment: Select WebIDE from Tools > Web Developer

Comment 5

[David Critchley (:dcritch)]

Attachment: Select Manage Extra Components from the Project menu

Comment 6

[David Critchley (:dcritch)]

Attachment: WebIDE Addon Manager interface

Comment 7

[Mike de Boer [:mikedeboer]]

There are two general points I'd like to make:

1) I'm unaware that you can be assigned and work on a meta bug, or is it in fact not? If not, we should change the summary.
2) I think we ought to refrain from dividing the team in two camps, chrome and webby folks, and rely on each to pick things up where the other can't reach. I think that if we're looking for a PoC, anyone can and should be able to get started and cut 'n paste something together.

I think it's great that you reached out to these relevant people and gathered this information. Now it's time to move forward and create a simple-as-possible-perhaps-even-ugly PoC patch.

Comment 8

[Mark Banner (:standard8)]

(In reply to Mike de Boer [:mikedeboer] from comment #7)
> 1) I'm unaware that you can be assigned and work on a meta bug, or is it in
> fact not? If not, we should change the summary.

We discussed at standup and agreed to put the findings on the bug. We do have history of assigning to metas, and this is for doing breakdowns, which I think this what its picking up from.


Dave: as discussed yesterday, I think we should get you pairing with either Mike or Dan probably (if you haven't started already). I'd suggest doing the PoC work in a separate newly filed bug.

Comment 9

[Mark Banner (:standard8)]

The PoC was completed in bug 1230236. At the current time, its believed that we no longer need this as we'll be using the go faster mechanisms.

Therefore I'm marking as invalid for now. We can always re-open if we do need it later.