1228934 - remove more parameters (style, weight, stretch) to nsFont constructor

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In https://hg.mozilla.org/integration/mozilla-inbound/rev/e1fd92eeb5ba I removed a parameter to the nsFont constructor.

But there are three other parameters that are passed as the same value by all callers of those constructors.  Given that long constructors are pretty unreadable anyway, and most if not all C++ callers want "NORMAL" for style, weight, and stretch (choosing the font style in a C++ constructor is a bit silly anyway), may as well remove them too.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Remove style, weight, and stretch parameters from nsFont constructor

Comment 2

[John Daggett (:jtd)]

Comment on attachment 8693449 [details] [diff] [review]
Remove style, weight, and stretch parameters from nsFont constructor

Review of attachment 8693449 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/99a32ec308b8229bf6daf9815d66b6e12fdcd817
Bug 1228934 - Remove style, weight, and stretch parameters from nsFont constructor.  r=jdaggett

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/99a32ec308b8

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

Is there any particular reason why we want to leave members uninitialized?

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

for nsFont::nsFont().

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Probably to avoid spending the time to initialize them... though it's not necessarily a good reason.

I also don't think that constructor was used much; it might be worth seeing if it could be removed.