1229492 - Hello fails on Linux as a system add-on due to platform.css missing

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

On Linux, Hello is currently failing, Randell reported that it has the Hello button, but it fails to load anything.

Exception on the console:

1448984590850   addons.xpi WARN     Exception running bootstrap method startup on [e-mail]: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIStyleSheetService.loadAndRegisterSheet]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm -> file:///home/jesup/src/mozilla/inbound/obj-x86_64-unknown-linux-gnu-debug/dist/bin/browser/features/[e-mail]/bootstrap.js :: startup :: line 775"  data: no] Stack trace: startup()@resource://gre/modules/addons/XPIProvider.jsm -> file:///home/jesup/src/mozilla/inbound/obj-x86_64-unknown-linux-gnu-debug/dist/bin/browser/features/[e-mail]/bootstrap.js:775 < this.XPIProvider.callBootstrapMethod()@resource://gre/modules/addons/XPIProvider.jsm:4587 < this.XPIProvider.startup()@resource://gre/modules/addons/XPIProvider.jsm:2723 < callProvider()@resource://gre/modules/AddonManager.jsm:227 < _startProvider()@resource://gre/modules/AddonManager.jsm:833 < AddonManagerInternal.startup()@resource://gre/modules/AddonManager.jsm:1016 < this.AddonManagerPrivate.startup()@resource://gre/modules/AddonManager.jsm:2781 < amManager.prototype.observe()@addonManager.js:58 

Not sure why this didn't show up on mochitests.

Comment 1

[Mark Banner (:standard8)]

Attachment: Hello fails on Linux as a system add-on due to trying to load platform.css that doesn't exist.

There's two routes we could have gone here, one was to add an empty platform.css, the second which I'm doing is to skip trying to load it for Linux.

I went for the second as it seemed slightly better performance wise overall.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8694393 [details] [diff] [review]
Hello fails on Linux as a system add-on due to trying to load platform.css that doesn't exist.

Review of attachment 8694393 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/51508d3c41d9

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/51508d3c41d9

Comment 5

[Bogdan Maris, Desktop QA]

Reproduced the exception from console using an old Nightly (2015-12-01) on Ubuntu 12.04 32-bit, and verified that using latest Nightly 45.0a1 I don't have the same behavior.