1229508 - [EME] Rev GMP_API_DECRYPTOR and support current and prev rev

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

In bug 1227790 I updated the MediaKeyStatus enum, and the GMPKeyStatus enum. But if Adobe's GMP uses the new GMPKeyStatus enum values in an old version of Firefox which doesn't support them, Firefox will kill the GMP.

So we should rev GMP_API_DECRYPTOR, and support the current and previous version of it in Firefox. Then the GMP can know it's safe to use the new enum values, as we'll request the newer GMP_API_DECRYPTOR actor.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: MozReview Request: Bug 1229508 - Support current and previous GMP_API_DECRYPTORs. r?gerald

Bug 1229508 - Support current and previous GMP_API_DECRYPTORs. r?gerald

To allow GMPs time to update to new GMPDecryptor versions, we support the
latest GMPDecryptor version, and the previous.

In order to support a consistent interface to Gecko, we adapt the previous
GMPDecryptor version to the latest in the GMP child process.  So Gecko always
thinks it's talking to the latest version.

We also make gmp-fake deliberately support the previous GMPDecryptor version,
to ensure this code path remains tested.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8694521 [details]
MozReview Request: Bug 1229508 - Support current and previous GMP_API_DECRYPTORs. r?gerald

https://reviewboard.mozilla.org/r/26817/#review24227

All good, assuming that the GMPs will do the right thing with enum values between API versions (which Adobe should, as discussed on IRC).

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/98052e9e211a

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98052e9e211a