Closed
Bug 1230221
Opened 8 years ago
Closed 8 years ago
Convert JS callsites to use asyncOpen2 within services/
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
Attachments
(1 file)
6.69 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8695364 -
Flags: review?(jonas)
Comment on attachment 8695364 [details] [diff] [review] bug_1230221_asyncopen2_services.patch Review of attachment 8695364 [details] [diff] [review]: ----------------------------------------------------------------- r=me with that fixed. ::: services/common/rest.js @@ +86,5 @@ > > // If we don't have an nsIURI object yet, make one. This will throw if > // 'uri' isn't a valid URI string. > if (!(uri instanceof Ci.nsIURI)) { > + uri = NetUtil.newURI(uri); Note, do keep this. ::: services/sync/modules/resource.js @@ +148,5 @@ > // through. It is never called directly, only {{{_doRequest}}} uses it > // to obtain a request channel. > // > _createRequest: function Res__createRequest(method) { > + let uri = NetUtil.newURI(this.spec); No need to create the URI here though.
Attachment #8695364 -
Flags: review?(jonas) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/3aacf4a71634 (along with the other bugs from this push) for failures: https://treeherder.mozilla.org/logviewer.html#?job_id=18296895&repo=mozilla-inbound
Flags: needinfo?(mozilla)
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #4) > Backed out in > https://hg.mozilla.org/integration/mozilla-inbound/rev/3aacf4a71634 (along > with the other bugs from this push) for failures: > https://treeherder.mozilla.org/logviewer.html#?job_id=18296895&repo=mozilla- > inbound I am not sure that this bug is causing the problem, but I'll investigate. Thanks Wes!
Flags: needinfo?(mozilla)
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2f0efcc5f4f7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•