Closed Bug 1230223 Opened 9 years ago Closed 9 years ago

Talos should exit early on TART timeout

Categories

(Testing :: Talos, defect)

Product:
Testing
Component:
Talos
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: parkouss, Assigned: parkouss)

Details

Attachments

(1 file, 1 obsolete file)

talos_tart_timeout.patch
2.18 KB, patch
parkouss
: review+
Details | Diff | Splinter Review 
Right now when we have a TART timeout (see bug 1052467) the jobs takes more than an hour to complete, and 50 minutes are spent waiting for the process to finish (example, https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=2797880).

We should exit talos on error as soon as the TART timeout is detected.
Bug 1230223 - Talos should exit early on TART timeout. r=jmaher
Attachment #8695361 - Flags: review?(jmaher)
Comment on attachment 8695361 [details]
MozReview Request: Bug 1230223 - Talos should exit early on TART timeout. r=jmaher

https://reviewboard.mozilla.org/r/27079/#review24483

this looks great!
Attachment #8695361 - Flags: review?(jmaher) → review+
This last try is good - we now fail early with that patch.
So, this is the patch reviewed by :jmaher (with a addition of one line to make it work!) - we discussed that on irc, so moving the r+ from my previous patch.
Attachment #8695361 - Attachment is obsolete: true
Attachment #8695739 - Flags: review+
Inbound is closed right now, asking for checkin-needed.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b57cc7221eec
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: