Closed
Bug 1230403
Opened 9 years ago
Closed 9 years ago
IonMonkey: MIPS: Add add64 to mips32
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: hev, Assigned: hev)
Details
Attachments
(1 file, 1 obsolete file)
2.22 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
Implement add64(Register, Register) to mips32.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8695642 -
Flags: review?(arai.unmht)
Comment 2•9 years ago
|
||
Comment on attachment 8695642 [details] [diff] [review] 0001-IonMonkey-MIPS-Add-add64-to-mips32.patch Review of attachment 8695642 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jit/mips32/MacroAssembler-mips32-inl.h @@ +83,5 @@ > +{ > + as_addu(ScratchRegister, dest.low, src.low); > + as_sltu(dest.low, ScratchRegister, dest.low); > + as_addu(dest.high, dest.high, src.high); > + as_addu(dest.high, dest.low, dest.high); The value of dest.low is incorrect. ScratchRegister contains |dest.low + src.low| value after those operations.
Attachment #8695642 -
Flags: review?(arai.unmht) → review-
Assignee | ||
Comment 3•9 years ago
|
||
Thank you!
Attachment #8695642 -
Attachment is obsolete: true
Attachment #8695703 -
Flags: review?(arai.unmht)
Comment 4•9 years ago
|
||
Comment on attachment 8695703 [details] [diff] [review] 0001-IonMonkey-MIPS-Add-add64-to-mips32.patch Review of attachment 8695703 [details] [diff] [review]: ----------------------------------------------------------------- nice fix :)
Attachment #8695703 -
Flags: review?(arai.unmht) → review+
Comment 6•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1c5bb0d79271
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•