1230403 - IonMonkey: MIPS: Add add64 to mips32

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

Implement add64(Register, Register) to mips32.

Comment 1

[hev [:hev]]

Attachment: 0001-IonMonkey-MIPS-Add-add64-to-mips32.patch

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8695642 [details] [diff] [review]
0001-IonMonkey-MIPS-Add-add64-to-mips32.patch

Review of attachment 8695642 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips32/MacroAssembler-mips32-inl.h
@@ +83,5 @@
> +{
> +    as_addu(ScratchRegister, dest.low, src.low);
> +    as_sltu(dest.low, ScratchRegister, dest.low);
> +    as_addu(dest.high, dest.high, src.high);
> +    as_addu(dest.high, dest.low, dest.high);

The value of dest.low is incorrect.
ScratchRegister contains |dest.low + src.low| value after those operations.

Comment 3

[hev [:hev]]

Attachment: 0001-IonMonkey-MIPS-Add-add64-to-mips32.patch

Thank you!

Comment 4

[Tooru Fujisawa [:arai]]

Comment on attachment 8695703 [details] [diff] [review]
0001-IonMonkey-MIPS-Add-add64-to-mips32.patch

Review of attachment 8695703 [details] [diff] [review]:
-----------------------------------------------------------------

nice fix :)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c5bb0d79271

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1c5bb0d79271