1230572 - Remove tcheck2

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

The tcheck2 test worked for the old JPZC because it used specific APIs to record checkerboarding that worked with JPZC. With the C++ APZ we have async subframe scrolling so the notion of checkerboarding is more complicated. We have plans to get detailed checkerboarding metrics in bug 1226826, and once we have that we should rewrite the tcheck2 test to use it.

Fundamentally I think the tcheck2 test should be written the same way it was before (i.e. load a page in Fennec, simulate a bunch of user actions, measure checkerboarding), but perhaps expand it to cover different kinds of sites.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: buildbot configs to turn off robocheck2 on all branches

here are the builders removed:
Builders removed
- Android 4.0 armv7 API 11+ alder talos remote-trobocheck2
- Android 4.0 armv7 API 11+ ash talos remote-trobocheck2
- Android 4.0 armv7 API 11+ b2g-inbound talos remote-trobocheck2
- Android 4.0 armv7 API 11+ cedar talos remote-trobocheck2
- Android 4.0 armv7 API 11+ fx-team talos remote-trobocheck2
- Android 4.0 armv7 API 11+ mozilla-aurora talos remote-trobocheck2
- Android 4.0 armv7 API 11+ mozilla-beta talos remote-trobocheck2
- Android 4.0 armv7 API 11+ mozilla-central talos remote-trobocheck2
- Android 4.0 armv7 API 11+ mozilla-inbound talos remote-trobocheck2
- Android 4.0 armv7 API 11+ try talos remote-trobocheck2

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 8695918 [details] [diff] [review]
buildbot configs to turn off robocheck2 on all branches

Review of attachment 8695918 [details] [diff] [review]:
-----------------------------------------------------------------

So after chatting on IRC with joel, we expect trobo2 to die completely, thus removing the config cruft will be a benefit.

Places I noticed
https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla-tests/mobile_config.py#158

https://dxr.mozilla.org/build-central/source/tools/trychooser/index.html#537

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/android/android_panda_talos_releng.py#53
https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos.json#111
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/scripts/android_panda_talos.py#68

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: buildbot configs to disable rck2 and other unused tests (2.0)

Comment 4

[Avi Halachmi (:avih)]

How about we call it tcheck3 ?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: mozilla-central - remove rck2 references (1.0)

this cleans up the talos.json and mozharness configs, pushed to try for sanity:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a72e080ac48a

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

landed the buildbot-config change:
https://hg.mozilla.org/build/buildbot-configs/rev/1f285543a146

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 8695937 [details] [diff] [review]
mozilla-central - remove rck2 references (1.0)

Review of attachment 8695937 [details] [diff] [review]:
-----------------------------------------------------------------

surprised we can kill this much kruft, but YAY that we can.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: clean up trychooser as well

Comment 9

[Kartikaya Gupta (email:[e-mail])]

I filed bug 1230598 for writing new tests since this one is being used for removing the old test.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

try chooser is landed:
https://hg.mozilla.org/build/tools/rev/fbe3196587fc

regarding the m-c bits, we need the buildbot-reconfig to take place first- we are scheduling rck2 still but there is no definition in mozharness/talos.json.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/faacb2337f8e

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/faacb2337f8e