1230576 - Shouldn't display error between the time commits are autolanded and when the results are available

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Mark Côté [:mcote]]

There's a brief period between when autoland has landed the commits on Try (or presumably other branches) and when results are available from Treeherder.  During this time you get

Commit(s) successfully landed on try
Error fetching the results for <revision> on try from Treeherder
Revision not found

There should be a special state here, with some sort of reasonable timeout, during which time something like "Waiting for results to be available on Treeherder for <revision> on try" is displayed.

Comment 1

[Mauro Doglio [:mdoglio]]

Attachment: MozReview Request: mozreview: better message when push not found on treeherder (bug 1230576); r?mcote

mozreview: better message when push not found on treeherder (bug 1230576); r?mcote

Comment 2

[Mauro Doglio [:mdoglio]]

Comment on attachment 8698458 [details]
MozReview Request: mozreview: better message when push not found on treeherder (bug 1230576); r?mcote

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28009/diff/1-2/

Comment 3

[Mark Côté [:mcote]]

Comment on attachment 8698458 [details]
MozReview Request: mozreview: better message when push not found on treeherder (bug 1230576); r?mcote

https://reviewboard.mozilla.org/r/28009/#review25071

::: pylib/mozreview/mozreview/static/mozreview/js/autoland.js:292
(Diff revision 1)
> -          $(actionMeta).text('Revision not found');
> +        $(actionHeading).text('Waiting for Treeherder to fetch the new info');

This is a little clumsy... maybe "Waiting for revision to appear in Treeherder"?

::: pylib/mozreview/mozreview/static/mozreview/js/autoland.js:294
(Diff revision 1)
> +      }else if (response.results.length > 1) {

Missing space after }.

Comment 4

[Mauro Doglio [:mdoglio]]

Comment on attachment 8698458 [details]
MozReview Request: mozreview: better message when push not found on treeherder (bug 1230576); r?mcote

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28009/diff/1-2/

Comment 5

[Mark Côté [:mcote]]

Comment on attachment 8698458 [details]
MozReview Request: mozreview: better message when push not found on treeherder (bug 1230576); r?mcote

https://reviewboard.mozilla.org/r/28009/#review25097