1230848 - Remove Gradle configuration rooted in the object directory

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Nick Alexander :nalexander [he/him]]

Now that Bug 1107811 and Bug 1123416 are landed, we can remove the stop-gap symlinking Gradle configuration in the object directory.  \o/

That means removing:

1) mach gradle-install;
2) mobile/android/gradle;
3) possibly mobile/android/base/docs/gradle.rst.  (Alternatively, update it.)

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1230848 - Remove Gradle configuration rooted in the object directory. r?gps

Bug 1230848 - Remove Gradle configuration rooted in the object directory. r?gps

The top source directory configuration requires
mobile/android/gradle/m2repo/**, so it stays.  There's no value
changing the location; it contains an Android-specific Gradle plugin.

We note the removal of |mach gradle-install| and point to the new
documentation.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8696372 [details]
MozReview Request: Bug 1230848 - Remove Gradle configuration rooted in the object directory. r?gps

https://reviewboard.mozilla.org/r/27317/#review25031

Sure.

FWIW, it is somewhat dangerous to assume there will only ever be a single Gradle/Android project in mozilla-central. I'd prefer things to be rooted under mobile/android. But I reckon we can cross this bridge another day. I also don't fully understand how this works. But meh.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Gregory Szorc [:gps] from comment #2)
> Comment on attachment 8696372 [details]
> MozReview Request: Bug 1230848 - Remove Gradle configuration rooted in the
> object directory. r?gps
> 
> https://reviewboard.mozilla.org/r/27317/#review25031
> 
> Sure.
> 
> FWIW, it is somewhat dangerous to assume there will only ever be a single
> Gradle/Android project in mozilla-central. I'd prefer things to be rooted
> under mobile/android. But I reckon we can cross this bridge another day. I
> also don't fully understand how this works. But meh.

I agree, but the IDEA-based environments assume all files referenced are under the root source directory.  Since we want to reference toolkit/ and other toplevel things, the root needs to be at the top level.

However, Gradle supports this all just fine.  We can move Android-specific things deeper into the tree (into mobile/android, for example) and grow a second configuration somewhere else.  (And IDEA-based environment support will work, to the best of my knowledge.)

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/93d733169c2151b471eab2a8c24a1ecd67487457
Bug 1230848 - Remove Gradle configuration rooted in the object directory. r=gps

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/93d733169c21