1231126 - If the active group had a name, the bookmark tab group migration names it Group (null) instead of its name

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Adrian Florinescu [:aflorinescu]]

Steps:
1. Open Nightly 44 -> Open panorama and create 3 tab groups.
2. Name the 3 tab groups. eg. G1, G2, G3.
3. Update to 45 Nightly.


Actual Result:
The 3 panorama groups will be migrated as Bookmarks: <Bookmark Menu/Bookmarked Tab Groups> as follows: G1 folder, G2 folder and insted of folder G3 I get "Group (null)".

Expected Result: 
Under <Bookmark Menu/Bookmarked Tab Groups> I expect 3 folders: G1, G2, G3.

Comment 1

[Adrian Florinescu [:aflorinescu]]

changing importance: data loss issue

Comment 2

[:Gijs (he/him)]

Please use a build that includes the fixes from bug 1229831.

Comment 3

[Adrian Florinescu [:aflorinescu]]

I'm a bit confused. The fix you pointed me is a 45 change set, while the migration is 44 nightly to 45 nightly.
Our tests  are performed on the last 44 nightly  (http://archive.mozilla.org/pub/firefox/nightly/2015/10/2015-10-29-03-02-58-mozilla-central/) which is migrated to the latest 45 Nightly: is this wrong?

Comment 4

[:Gijs (he/him)]

(In reply to Adrian Florinescu from comment #3)
> I'm a bit confused. The fix you pointed me is a 45 change set, while the
> migration is 44 nightly to 45 nightly.
> Our tests  are performed on the last 44 nightly 
> (http://archive.mozilla.org/pub/firefox/nightly/2015/10/2015-10-29-03-02-58-
> mozilla-central/) which is migrated to the latest 45 Nightly: is this wrong?

You have not identified which 45 build you're using, the exact bug you're reporting was already reported and fixed, and I cannot reproduce the issue you identified with a current 45 nightly build.

So I can only conclude that you tested with an older (ie not today's) 45 build.

To avoid issues like this, you should be including the buildid of the 45 build you used, which you still didn't do...

Comment 5

[Adrian Florinescu [:aflorinescu]]

The problem is reproducible on latest 45.0a1 / all OS versions.
I tested on:
Version: 	45.0a1
Build ID: 	20151208030212
User agent: Mozilla/5.0 (Windows NT 6.2; rv:45.0) Gecko/20100101 Firefox/45.0



Note: The "Group (null)" name is given only the the tab group you had a tab open from when you start upgrading. In the original bug, all groups with name would be migrated and saved as "Group (null)". You can decide if you want this tracked here or in the original issue you pointed.

Comment 6

[:Gijs (he/him)]

(In reply to Adrian Florinescu from comment #5)
> Note: The "Group (null)" name is given only the the tab group you had a tab
> open from when you start upgrading. In the original bug, all groups with
> name would be migrated and saved as "Group (null)".

Ah. But that wasn't what the summary said...

Comment 7

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1231126 - always use unique property name for group titles, r?felipe

Bug 1231126 - always use unique property name for group titles, r?felipe

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8696720 [details]
MozReview Request: Bug 1231126 - always use unique property name for group titles, r?felipe

https://reviewboard.mozilla.org/r/27415/#review24725

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e7862afd5e5c

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e7862afd5e5c

Comment 11

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on the latest nightly46(updated from nightly 44 to nightly 46) and aurora45(updated from aurora 44 to aurora 45) on the following OS.: Ubuntu14.04 x86, Windows 7 x64, Mac OSX 10.10:


Aurora45:
20151221004011 Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Firefox/45.0
20151221004011 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Firefox/45.0
20151221004011 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0

Nightly46:
20151221030239 Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0
20151221030239 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:46.0) Gecko/20100101 Firefox/46.0
20151220030223, Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0