1231256 - Remove lots of unused parameters, mostly in layout/xul/

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Nicholas Nethercote [inactive]]

I've been fiddling with -Wunused-parameter. Here are some things I've found with it.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove unused nsBoxLayoutState parameters from many functions

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove unused BlobDirState parameters from SetLazyData()

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Remove unused parameter from TryToOuterize()

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 4) - Remove dead SetContext() declaration

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: (part 5) - Remove dead FromCSSPerspectiveInfo() function

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: (part 6) - Remove unused parameter from Damage functions

Comment 7

[Nicholas Nethercote [inactive]]

Attachment: (part 7) - Remove unused parameters from two layout functions

Comment 8

[Nicholas Nethercote [inactive]]

Attachment: (part 9) - Remove unused parameter from ShowPopup()

Comment 9

[Nicholas Nethercote [inactive]]

Attachment: (part 10) - Remove unused parameters from StartAPZDrag()

Comment 10

[Nicholas Nethercote [inactive]]

Attachment: (part 11) - Remove unused parameter from HidePopupsInList()

Comment 11

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8696858 [details] [diff] [review]
(part 2) - Remove unused BlobDirState parameters from SetLazyData()

Review of attachment 8696858 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and I tracked this to bug 1177688 where nobody said anything about it, so I'm assuming it's as safe to remove as it looks.

Comment 12

[Nicholas Nethercote [inactive]]

Attachment: (part 12) - Remove TraceableVectorOperations::canAppendWithoutRealloc

It's unused.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8696859 [details] [diff] [review]
(part 3) - Remove unused parameter from TryToOuterize()

Review of attachment 8696859 [details] [diff] [review]:
-----------------------------------------------------------------

not my area, but trivial

Comment 14

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/182171efdc63a30529e7568a2215caa637fb4df0
Bug 1231256 (part 1) - Remove unused nsBoxLayoutState parameters from many functions. r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/62a5376b5872f56e6ca5f066707e9a51bb6f3cac
Bug 1231256 (part 2) - Remove unused BlobDirState parameters from SetLazyData(). r=jld.

https://hg.mozilla.org/integration/mozilla-inbound/rev/812c6950a3013d79064bf1e9048da4d9b57e2b7f
Bug 1231256 (part 3) - Remove unused parameter from TryToOuterize(). r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/38d815a88e45c302bdfa7b62538cb59ce9c77518
Bug 1231256 (part 4) - Remove dead SetContext() declaration. r=jfkthame.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ff479c4c0ccf2a8a3a35f45f3212115e4edfc82
Bug 1231256 (part 6) - Remove unused parameter from Damage functions. r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/721bc6e718a829a61a2fe407d48c04e7d47fce40
Bug 1231256 (part 7) - Remove unused parameters from two layout functions. r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8fe4c23ba7ee936a77e751f973bc8bc86b51ba9
Bug 1231256 (part 8) - Remove unused parameters from MouseClicked(). r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c96cf4a9adf4c153d4c3d117382b6a2e55b60035
Bug 1231256 (part 9) - Remove unused parameter from ShowPopup(). r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb400f0cd3f355c9d4dafd5b1461e9bedf086c41
Bug 1231256 (part 10) - Remove unused parameters from StartAPZDrag(). r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1a84550d4259710c073ed6202821c4715c230b4
Bug 1231256 (part 11) - Remove unused parameter from HidePopupsInList(). r=roc.

https://hg.mozilla.org/integration/mozilla-inbound/rev/0bcfe60c2977a6a0c93275aff8382a18677311ae
Bug 1231256 (part 12) - Remove TraceableVectorOperations::canAppendWithoutRealloc. r=terrence.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/182171efdc63
https://hg.mozilla.org/mozilla-central/rev/62a5376b5872
https://hg.mozilla.org/mozilla-central/rev/812c6950a301
https://hg.mozilla.org/mozilla-central/rev/38d815a88e45
https://hg.mozilla.org/mozilla-central/rev/6ff479c4c0cc
https://hg.mozilla.org/mozilla-central/rev/721bc6e718a8
https://hg.mozilla.org/mozilla-central/rev/f8fe4c23ba7e
https://hg.mozilla.org/mozilla-central/rev/c96cf4a9adf4
https://hg.mozilla.org/mozilla-central/rev/fb400f0cd3f3
https://hg.mozilla.org/mozilla-central/rev/b1a84550d425
https://hg.mozilla.org/mozilla-central/rev/0bcfe60c2977

Comment 16

[Nicholas Nethercote [inactive]]

Still waiting on r+ for part 5.

Comment 17

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5351257556f06ab75c88796b165d42347d54e61c
Bug 1231256 (part 5) - Remove dead FromCSSPerspectiveInfo() function. r=vlad.

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5351257556f0