1231489 - Custom properties of primitive prototypes are not autocompleted

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Simon Lindholm]

STR:
>> String.prototype.hello = 1
>> a = "hi"
>> a.h<tab>
should auto-complete to "a.hello", but does not. This happens because the browser chrome's String.prototype is used when converting "a" to an object, rather than the page's.

Also happens for numbers, symbols, etc., and for literal strings and arrays (through a separate but similar code path).

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1231489 - Use content prototype for autocompletion of String, Number and Array literals; r=bgrins.

When provided a string, number or array literals, we use to
simply return the properties from String.prototype, Number.prototype
and Array.prototype.
This is working fine unless the content prototypes are modified.
In order to make it work properly, we retrieve the actual content
prototype.
The js-property-provider unit test is modified to ensure this is
working as expected.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

TRY push https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b88a07e9e8bf2991b470e6dc494f79296b90bc1

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c65391dd1e7d
Use content prototype for autocompletion of String, Number and Array literals; r=bgrins.

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/c65391dd1e7d