1231627 - [Static Analysis][Unchecked return value] In function WebGLContextLossHandler::RunTimer() from WebGLContextLossHandler.cpp

Status: RESOLVED DUPLICATE of bug 1280507

(Core :: Graphics: CanvasWebGL, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that return value from workerPrivate->AddFeature(workerPrivate->GetJSContext(), this) is not checked.

>>        if (!mFeatureAdded) {
>>            workerPrivate->AddFeature(workerPrivate->GetJSContext(), this);
>>            mFeatureAdded = true;
>>        }

I've added these lines of code:
>>       if(NS_WARN_IF(!workerPrivate->AddFeature(workerPrivate->GetJSContext(), this)))
>>          return;
>>      else    
>>          mFeatureAdded = true;

That when AddFeature fails and it get called dirrectly from TimerCallback we should also be blocked by the assert and to signal a potential issue:

>>    if (mShouldRunTimerAgain) {
>>        RunTimer();
>>        MOZ_ASSERT(mIsTimerRunning);
>>    }

Now i'm not sure that we should have the return in the event AddFeature fails, but i put it there in order to signal that we no longer trigger a StartTimer.

Comment 1

[Andi [:andi]]

Attachment: Bug 1231627.diff

Comment 2

[Kelsey Gilbert [:jgilbert]]

Duping this to bug 1280507, since that bug removes this code.