Closed
Bug 1231650
Opened 9 years ago
Closed 9 years ago
Eslint in the github repo doesn't run against the whole repo
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
Iteration:
45.3 - Dec 14
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
When we set up eslint in the github repo, we accidentally specified directories for the command rather than the whole repo and relying on .eslintignore.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8697247 -
Flags: review?(edilee)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8697247 [details] [review] Link to Github pull-request: https://github.com/mozilla/loop/pull/2 These files are additionally linted with the change: bin/server.js test/karma/head.js test/karma/karma.conf.base.js test/karma/karma.coverage.desktop.js test/karma/karma.coverage.shared_standalone.js ui/fake-l10n.js ui/fake-mozLoop.js ui/react-frame-component.js ui/ui-showcase.jsx
Attachment #8697247 -
Flags: review?(edilee) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://github.com/mozilla/loop/commit/caf7e2d1120a05e326f08e19d629ba4afc33706d
Status: NEW → RESOLVED
Iteration: --- → 45.3 - Dec 14
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•