Closed
Bug 1231834
Opened 8 years ago
Closed 8 years ago
Add manifest file for shared B2G repositories
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tzimmermann, Assigned: tzimmermann)
Details
Attachments
(1 file)
Some repositories are shared by all targets. We should put them in a separate file for convenience.
Assignee | ||
Comment 1•8 years ago
|
||
This is supposed to simplify repo handling a bit.
Attachment #8697417 -
Flags: review?(jgomez)
Comment 2•8 years ago
|
||
I disagree with moving all remotes to a single file. Common remotes might fine, but device specific ones really do not belong.
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Michael Wu [:mwu] from comment #2) > I disagree with moving all remotes to a single file. Common remotes might > fine, but device specific ones really do not belong. Yeah. I was undecided about this. There are some remotes that are used by more than one manifest, but only a few; like "linaro". Do you have a suggestion where to draw the line for sharing remotes? More than one or two targets?
Comment 4•8 years ago
|
||
I think that by common remotes, we mean: aosp, caf, mozilla and b2g. All other remotes are usually very device specific (sprd, t2m, allwinner, ... ). So I'd suggest to move the former to a common file and keep the latter into the specific device manifest.
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8697417 [details] [review] Github pull request Updated Github pull request * moved device-specific repos back into device manifests * apitrace it used by almost every device, so I kept it in base.xml
Updated•8 years ago
|
Attachment #8697417 -
Flags: review?(jgomez) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8697417 [details] [review] Github pull request Changes to Github pull request - rebased onto latest master branch
Assignee | ||
Comment 7•8 years ago
|
||
https://github.com/mozilla-b2g/b2g-manifest/commit/62a18ffc03aad7ea10f84e22ad04bd3987777805
Assignee | ||
Comment 8•8 years ago
|
||
Apparently no build problems showed up. I'm closing the bug as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•