1231956 - Add devtools files to .eslintignore

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Run ./mach eslint and add all devtools files that have warnings or errors to .eslintignore so that `./mach eslint` at root level passes.

Comment 1

[Kartikey Agrawal[:kartikey0303]]

I am new to open source community. Can I work on this bug? This being my first bug I will probably need lots of help.

Comment 2

[Patrick Brosset <:pbro>]

I think we can proceed in steps.
First step would be to ignore the whole devtools/ directory. Which would mean adding 'devtools/**' in this file: https://dxr.mozilla.org/mozilla-central/source/.eslintignore
Second steps would be enabling directories one by one, and adding specific exclusion in .eslintignore. But that should be done as a child bug of bug 1231957.

Not so sure this is a good first bug after all in fact.

Comment 3

[Dave Townsend [:mossop]]

Attachment: MozReview Request: Bug 1231956: Add devtools to .eslintignore. r?pbro

Devtools has a lot of eslint failures right now that would block us from turning
on compile time eslint checks in bug 1229588. For now I'd like to just ignore
the directory and then you can work to clean up the warnings and re-enable
checks at whatever pace you like.

Review commit: https://reviewboard.mozilla.org/r/30405/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30405/

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8706617 [details]
MozReview Request: Bug 1231956: Add devtools to .eslintignore. r?pbro

https://reviewboard.mozilla.org/r/30405/#review27213

Thanks for taking care of this Dave.
Can you remind me how we can still run ESLint locally with the folder excluded though? I know there's a way.

Comment 5

[Dave Townsend [:mossop]]

(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #4)
> Comment on attachment 8706617 [details]
> MozReview Request: Bug 1231956: Add devtools to .eslintignore. r?pbro
> 
> https://reviewboard.mozilla.org/r/30405/#review27213
> 
> Thanks for taking care of this Dave.
> Can you remind me how we can still run ESLint locally with the folder
> excluded though? I know there's a way.

Add --no-ignore to the command line.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2feec42daf62

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2feec42daf62