1232245 - Use GitHub instead of SVN as localization source

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Francesco Lodolo [:flod]]

We need to update scripts to pick up strings from GitHub instead of SVN.

Comment 1

[Francesco Lodolo [:flod]]

Looks like I lost track of how things work
https://github.com/mozilla/firefox-ios/commit/074677e714a7a4991c74ceafc568fcf9b15af67f

Removed the /scripts folder completely and moved it to
https://github.com/mozilla/firefox-ios-build-tools

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

This should be good for review, but we need to make sure we don't have delays on the tools' side before merging.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8697960 [details] [review]
Pull request on Github

Emily can you merge this if it looks good?

Comment 5

[Emily Toop (:fluffyemily)]

PR merged. Not closing bug as there is a small amount of work to do to get things working with fastlane

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Pushed some small fixes that I discovered while running the export-locales script:

https://github.com/mozilla/firefox-ios-build-tools/commit/a299e23bb1fcdfb6f8fed16609f2cdf9bf804e2e

Comment 7

[Francesco Lodolo [:flod]]

Attachment: Improve workflow in export-locales.sh

I'm making a few assumptions based on the existing paths (didn't find any documentation): 
* The firefox-ios-build-tools folder is placed at the same level as firefox-ios
* The script is run from the main project folder as ../firefox-ios-build-tools/scripts/export-locales.sh

Improvements:
* Reuse existing virtualenv by default, since setting it up takes forever. Run with 'clean' parameter to set up a new virtualenv
* Create a branch in the l10n repository, commit file individually. I've left the 'git push' command commented out, but it could be changed.

Note: the main repository should really have firefox-ios-l10n and export-locales-env in .gitignore

Comment 8

[Emily Toop (:fluffyemily)]

Attachment: Don't commit firefox-ios-l10-n repo for fastlane purposes

Comment 9

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8703585 [details] [review]
Don't commit firefox-ios-l10-n repo for fastlane purposes

LGTM

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8703250 [details] [review]
Improve workflow in export-locales.sh

LGTM Please test it well

Comment 11

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8703250 [details] [review]
Improve workflow in export-locales.sh

LGTM Please test it well

Comment 12

[Francesco Lodolo [:flod]]

NI for Stefan to merge the PR. Once merged we can close this bug for good.

Comment 13

[Francesco Lodolo [:flod]]

Thanks Emily for the merge, we can close this bug.