Closed
Bug 1232280
Opened 9 years ago
Closed 9 years ago
Implement test_home_button.py and test_home_button_in_edit_mode.py as an Integration test in JavaScript
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.6 S3 - 12/18
People
(Reporter: jlorenzo, Assigned: gmarty)
References
Details
(Whiteboard: [gip-to-gij][systemsfe])
Attachments
(1 file)
Bug 1195364 was started as a Python test, but pressing the home button like we do in this test is actually like we should do in an integration test. I couldn't find an equivalent of [1] in the Gij suite. [1] https://github.com/mozilla-b2g/gaia/pull/31423/files#diff-9f1ebdc2a3cc811a6deb601c9ba24d27
|
Reporter | |
Comment 1•9 years ago
|
||
test_home_button_in_edit_mode.py[1] can also be added along the same test file. [1] https://github.com/mozilla-b2g/gaia/pull/31423/files#diff-a2d567c9ffb6d3ba89a67dead18f1a3f
Summary: Implement test_home_button.py as an Integration test in JavaScript → Implement test_home_button.py and test_home_button_in_edit_mode.py as an Integration test in JavaScript
|
||
Comment 2•9 years ago
|
||
Guillaume, can you help out here?
Flags: needinfo?(gmarty)
Whiteboard: [gip-to-gij] → [gip-to-gij][systemsfe]
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → gmarty
Flags: needinfo?(gmarty)
|
||
Comment 3•9 years ago
|
||
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8699518 [details] [review] [gaia] gmarty:Bug-1232280-homescreen-home-button-gip-to-gij > mozilla-b2g:master Pre-emptive r+, lgtm.
Attachment #8699518 -
Flags: review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Ah ah! Amazing Chris, so fast. Thanks a lot! Let's see what Gaia Try thinks of it now.
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/37210d8e5376b514bef74048cc49043fc88d7954
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S3 - 12/18
You need to log in
before you can comment on or make changes to this bug.
Description
•