1232313 - Autophone - Mdm failure - dom/media/test/test_unseekable.html | Test timed out

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Bob Clary [:bc] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a99d064ef982&exclusion_profile=false&selectedJob=14568920

Nexus 5 Android 4.4

>TEST-TIMEOUT | dom/media/test/test_unseekable.html | Test timed out.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: street.mp4 playback error

This looks like an actual bug, we fail playing dom/media/test/street.mp4 on Android (tested on Nexus 7 Android 6.0.1).

I've moved the file to http://me73.com/media/street.mp4 for testing.

jya, are there known issues with fragmented MP4 playback on modern Android or is it something specific about this file we don't like?

Comment 2

[Jean-Yves Avenard [:jya]]

the mp4 demuxer is identical across all platforms, we use our own.

So, no, I'm not aware of any issues there when it comes to the demuxer.

Comment 3

[Eugen Sawin [:esawin]]

I've added a test page which is supposed to auto-play street.mp4, and it fails in the same way on Windows and Linux desktop (see log in comment 1): http://me73.com/media/frag.html.

Manually starting playback seems to work (though it's hard to tell since the video is too short to display anything).

jya, this seems to be a general demuxer issue we have with auto-playing street.mp4.

Comment 4

[Jean-Yves Avenard [:jya]]

yes, this file is missing tfdt box in the moof.

ISO 14496-12 states that this box is not compulsory and is only used to determine the time of the first sample in this fragment.

otherwise you have to use the total duration + time of all the samples prior...

I'll implement that ASAP.

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1232313: [mp4] Use cumulative decode time if tfdt box is not present. r=kentuckyfriedtakahe

Per ISO 14496-12, the Track fragment decode time (tfdt) is optional.

Review commit: https://reviewboard.mozilla.org/r/40357/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40357/

Comment 6

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8731105 [details]
MozReview Request: Bug 1232313: [mp4] Use cumulative decode time if tfdt box is not present. r=kentuckyfriedtakahe

https://reviewboard.mozilla.org/r/40357/#review36893

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ed310b4f4d0

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0ed310b4f4d0

Comment 9

[Jean-Yves Avenard [:jya]]

Comment on attachment 8731105 [details]
MozReview Request: Bug 1232313: [mp4] Use cumulative decode time if tfdt box is not present. r=kentuckyfriedtakahe

Approval Request Comment
[Feature/regressing bug #]: 1232313
[User impact if declined]: some files won't play. Blocking bug 1269325 which has been beta+
[Describe test coverage new/current, TreeHerder]: Committed over 2 months ago, in 48 already
[Risks and why]: Very low. just going per spec.
[String/UUID change made/needed]: none

Comment 10

[Jean-Yves Avenard [:jya]]

bug 1269325 was approved for uplift, but it relies on this change to be in first.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8731105 [details]
MozReview Request: Bug 1232313: [mp4] Use cumulative decode time if tfdt box is not present. r=kentuckyfriedtakahe

Media playback issues, Beta47+

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5cf27273ecde