1232374 - remove nsAutoArrayPtr usages from toolkit/

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Nathan Froyd [:froydnj]]

There are just a handful of these:

https://dxr.mozilla.org/mozilla-central/search?q=nsAutoArrayPtr+path%3Atoolkit&redirect=true&case=false

They should be converted to use UniquePtr<T[]> instead; the idiomatic way of declaring and defining a UniquePtr is:

auto var = MakeUnique<T[]>(length);

Since nsAutoArrayPtr implicitly converts to T* and UniquePtr does not, you'll have to add |.get()| calls for all uses of the raw pointer.  Accesses such as |var[i]| do not need any special treatment.

Comment 1

[Andrew McCreight [:mccr8]]

Haik, this would be a good simple first bug to get used to the whole patch workflow. Nathan came up with this for you.

Comment 2

[Haik Aftandilian [:haik]]

Attachment: remove nsAutoArrayPtr usages from toolkit/

This is my try link,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1179a98c6208
A bug was found in the version submitted to try. Executing the
profile manager locally crashed on exit. Fixed that bug in this
patch. Did not re-run try.

Comment 3

[Haik Aftandilian [:haik]]

Comment on attachment 8699125 [details] [diff] [review]
remove nsAutoArrayPtr usages from toolkit/

Removed from NULL checks that no longer needed due to infallible allocation.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a20e57b2fd30

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a20e57b2fd30