1232473 - about:home pocket snippet doesn't work if account set up

Status: RESOLVED FIXED

(Snippets Graveyard :: General, defect)

Description

[Robert Helmer [:rhelmer]]

Attachment: Screen Shot 2015-12-14 at 2.30.49 PM.png

Because the snippet runs on about:home, if a user has already logged into Pocket then clicking on the snippet displays "Page Not Saved: Only links can be saved".

This is when clicking on the Pocket icon or "Try it now" in the snippet.

If not yet logged into Pocket, then the flow is more useful (prompts to set up or sign into account etc)

Comment 1

[Justin Dolske [:Dolske]]

The snippet's JS has a click handler that's called when the "try it now" text is clicked. This in turn calls Mozilla.UITour.showMenu('pocket'), which opens the pocket menu. (Assuming it's an available target, which is checked.) There's no tour-exposed mechanism to see if a user is already logged in to Pocket, so I don't think this is fixable from content.

The snippet is also misleading, because there's no offline support in Pocket for desktop.

I think we should disable this snippet.

Comment 2

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Jessica - could we please disable the Pocket snippets per the reasons in comment 1?

We originally launched these snippets when Pocket was first introduced and understood that the majority of users would not have a login already. I think if we want to deploy another promotion we'll have to reconsider implementation.

Thanks.

Comment 3

[Jessica]

(In reply to Cory Price [:ckprice] from comment #2)
> Jessica - could we please disable the Pocket snippets per the reasons in
> comment 1?
> 
> We originally launched these snippets when Pocket was first introduced and
> understood that the majority of users would not have a login already. I
> think if we want to deploy another promotion we'll have to reconsider
> implementation.
> 
> Thanks.

Hi Cory  - Thanks for flagging this.  I just disabled those snippets.  

I can promote via simple snippet perhaps and just send them to the pocket feature page.   I'll ping you today to confirm.

Thanks again,

Jess

Comment 4

[Justin Dolske [:Dolske]]

(In reply to Cory Price [:ckprice] from comment #2)
> I
> think if we want to deploy another promotion we'll have to reconsider
> implementation.

It would probably be fairly simple to just expose the logged-in-or-not state via the UITour API. (famous last off-the-cuff words ;)

Comment 5

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

(In reply to Justin Dolske [:Dolske] from comment #4)
> It would probably be fairly simple to just expose the logged-in-or-not state
> via the UITour API. (famous last off-the-cuff words ;)
bug 1233973 :D

Closing this bug for now. Whenever bug 1233973 gets addressed we can look into running this back.