1232720 - Change the `make xpi` command to produce a clean xpi that is suitable for uploading/publishing

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Currently the `make xpi` command produces something that includes tests, .eslintrc files etc. We need to produce an xpi which is just the required parts.

I think the best thing here would be to use a dist to create a clean directory, which we then generate the xpi from.

This bug will ignore locale issues, we'll deal with those in a follow-up.

Comment 1

[Mark Banner (:standard8)]

Probably also depends on bug 1232707 as some of this is overlapping work.

Comment 2

[GitHub Autolander Bot]

Attachment: [loop] Standard8:bug-1232720-xpi > mozilla:master

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8700783 [details] [review]
[loop] Standard8:bug-1232720-xpi > mozilla:master

Mike, Chris, could one of you review this please?

This gets us preprocessing of the xpi, and a `make dist` command that generates the xpi for us.

There's probably some parts that could be improved, but I think its fairly good as it is for now, and we can ship an xpi with this.

Comment 4

[Mark Banner (:standard8)]

I've just pushed a slight update to the PR to make sure that the xpi is generated every time the `make dist` command is run.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8700783 [details] [review]
[loop] Standard8:bug-1232720-xpi > mozilla:master

Ed has been looking at this.

Comment 6

[Ed Lee :Mardak]

Comment on attachment 8700783 [details] [review]
[loop] Standard8:bug-1232720-xpi > mozilla:master

r=Mardak looks good with minor spacing nits

Comment 7

[Mark Banner (:standard8)]

https://github.com/mozilla/loop/commit/1942f25198436cf77a9dcd860092d5bbcd6ea77f