1233032 - about:profiles, It is not clear which profile to be subjected to "Start Nightly"

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Alice0775 White]

STR
0. Provide many profile
1. start firefox.exe -P

Actual Results:
 It is not clear which profile to be subjected to "Start Nightly", "Restart with Add-ons Disabled..." and "Restart normally..."
Expected Results:
Should indicate which profile to be subjected to these button.

Comment 1

[Andrea Marchesini [:baku]]

those entries are not shown once bug 1233007 is landed.

Comment 2

[Alice0775 White]

Bug 1233007 is landed, however, I cannot distinguish which profile is used for "Start Nightly"  button.

STR
0. Provide many profile
1. start firefox.exe -P

Actual Results:
 It is not clear which profile to be subjected to "Start Nightly"

Expected Results:
Should indicate which profile to be subjected to.

Comment 3

[Alice0775 White]

I think "Start Nightly" should use "Last used profile" or "Newly Created Profile"

Comment 4

[Tracy Walker [:tracy]]

It is not obvious which profile will be run.  Best I could tell is that you have to set the profile you want to use as the "Default."  

However, it takes two attempts to switch profiles as follows:

1) Set the profile you want to use as default. (ensure it says "yes" as default in that profile listing, all other profiles should say "no" for the same)
2) Start nightly. (result: Nightly does not start up in the profile just selected as default, instead it started with the profile that was previously set as default)
3) Shutdown Nightly.
4) Start Nightly again to get about:profiles. In about:profiles, note that the profile you want to start Nightly with is still set as default, then start Nightly.  

Finally, the browser is running the profile I intend to use.

It should be more clear how to select a profile for use. The browser should start with the selected profile the first time.

Comment 5

[Tracy Walker [:tracy]]

It is also not possible to run two browsers simultaneously through the new profile management system of about:profile.  With one latest Nightly already running, attempt to run a second latest Nightly installation is not possible, as you must switch the default profile, which you can't do because the default profile is already in use (reported by a dialog).

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

[Tracking Requested - why for this release]:
I think all has been said here already. It's a pain right now to start Firefox with the wanted profile. Especially if multiple instances of Firefox have to run. 

Please get this fixed and make it obvious which is the profile to start Firefox with.

Comment 7

[Andrea Marchesini [:baku]]

Attachment: profile8.patch

Comment 8

[(no longer active)]

Can you please explain what your patch is trying to do?  Thanks!

Comment 9

[Andrea Marchesini [:baku]]

This patch changes:

1. |<h2>name of the profile</h2>| in |<h2><input type="radio" name="profile" value="name of the profile" />name of the profile</h2>|. Of course only in about:profile?manage

2. when a new profile is created, we set it as 'selected' by default (input type="radio" checked)

3. when a profile is selected (input.onchange) we set that as the selected profile.

4. clicking on 'start nightly' we open the selected profile.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Andrea Marchesini (:baku) from comment #9)
> 2. when a new profile is created, we set it as 'selected' by default (input
> type="radio" checked)

Which does not mean being the default profile, right? That would not be that ideal if you have to create new profiles for testing a lot.

Comment 12

[Andrea Marchesini [:baku]]

> Which does not mean being the default profile, right? That would not be that
> ideal if you have to create new profiles for testing a lot.

Correct: The selected profile is 'selected' because the user wants to open it, and that means that the input type=radio is checked.  The default browser is the profile opened in case the user doesn't select a different profile manually via profileManager. This means, opening firefox, by default we open the default profile. With the profileManager you can 'select' to open the profile you prefer for that particular firefox instance.

Comment 13

[(no longer active)]

Comment on attachment 8699797 [details] [diff] [review]
profile8.patch

Review of attachment 8699797 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutProfiles.js
@@ +101,5 @@
> +  if (gManage) {
> +    let checkBox = document.createElement('input');
> +    checkBox.setAttribute('type', 'radio');
> +    checkBox.setAttribute('name', 'profile');
> +    checkBox.setAttribute('value', profileData.profile.name);

You don't need to set @value, I think.

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c64b18f74a7

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3c64b18f74a7