1233171 - ScriptLoader should cancel channel when aborting due to cancelation

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

In bug 1229970 I added a short-circuit failure path if another script in the load was canceled or failed.  That avoided a crash.

I see now, though, that I did not cancel the channel.  All the other error paths do this and so should this one.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Cancel channel when ScriptLoader is aborted during service worker script load. r=khuey

Something I missed in the patch you reviewed for me last week.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8699137 [details] [diff] [review]
Cancel channel when ScriptLoader is aborted during service worker script load. r=khuey

Review of attachment 8699137 [details] [diff] [review]:
-----------------------------------------------------------------

Is it possible to test this somehow?

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

I don't know how to write a test for this that wouldn't be incredibly racy.  I think this change is clearly correct, though, so I would like to land it.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd4fe7efeb47

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd4fe7efeb47