1233189 - Duplicated string first_time_experience_button_label in loop.properties

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Francesco Lodolo [:flod]]

http://hg.mozilla.org/mozilla-central/diff/ec836d27b563/browser/locales/en-US/chrome/browser/loop/loop.properties

There was already such string with a different value
first_time_experience_button_label=Get Started

Considering that, I expect English to not show the correct text either.

Comment 1

[Francesco Lodolo [:flod]]

NI for visibility, even if we're at the very beginning of the cycle.

Comment 2

[Chris Rafuse :crafuse]

Dan, Does this need to happen in gecko-dev/Mozilla Central?

REMOVE:
first_time_experience_button_label=Get Started


Increment and translate for:
first_time_experience_button_label=See how it works
TO:
first_time_experience_button_label2=See how it works

Change to:
add-on/panels/js/panel.jsx
38:                  caption={mozL10n.get("first_time_experience_button_label2")}

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

I have mixed feelings on this one.  Deferring to Standard8 in case he has a strong opinion...

Comment 4

[Mark Banner (:standard8)]

As this is broken, lets get it fixed on m-c so that its better for localisers for now.

Comment 5

[Daniel Holbert [:dholbert]]

FWIW, this issue causes a warning to be spammed to the terminal, too (during startup on debug builds at least):
  WARNING: the property first_time_experience_button_label already exists
  : file ../../../mozilla/xpcom/ds/nsPersistentProperties.cpp, line 532

Comment 6

[Chris Rafuse :crafuse]

Attachment: Duplicated string first_time_experience_button_label in loop.properties

Comment 7

[Chris Rafuse :crafuse]

Comment on attachment 8699777 [details] [diff] [review]
Duplicated string first_time_experience_button_label in loop.properties

Removed string property and modified display location.

Needs to eventually be synced with loop master.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8699777 [details] [diff] [review]
Duplicated string first_time_experience_button_label in loop.properties

Looks good. r=Standard8

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ff3fcdae5d51

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ff3fcdae5d51