Closed
Bug 1233644
Opened 9 years ago
Closed 8 years ago
use pattern matching when listening clear-origin-data in ServiceWorkerManager
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
Attachments
(1 file, 4 obsolete files)
15.92 KB,
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
See Honza's comment in https://bugzilla.mozilla.org/show_bug.cgi?id=1233136#c0 "ServiceWorkerManager [2], bug 1191647, that doesn't build OriginAttributesPattern from aData"
Assignee | ||
Comment 1•8 years ago
|
||
WIP, still have problems on writing tests.
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=680b69b15865
Assignee | ||
Comment 3•8 years ago
|
||
Thanks to :kanru's help, I get the tests running. :D
Attachment #8699940 -
Attachment is obsolete: true
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4f533ad0b90
Assignee | ||
Comment 5•8 years ago
|
||
fixed some try failure
Attachment #8700559 -
Attachment is obsolete: true
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8700931 -
Attachment is obsolete: true
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8700932 [details] [diff] [review] Patch. Review of attachment 8700932 [details] [diff] [review]: ----------------------------------------------------------------- Hi Ben The handling of clear-origin-data landed in Bug 1191647 has some problems, for example, when the data is {appId: 1} in clear-origin-data, we should clear all registrations for appId = 1, whether the inBrowser flag is true or not. Right now the code will only clear the registration {appId: 1, inBrowser: false} Also test is included, in the test I need a mozbrowser frame which needs 'browser' permission, to prevent adding more permissions into the original app, so I create another test app, which is copied the test app from dom/workers/test/serviceworkers/app/ Could you review this for me? Thanks
Attachment #8700932 -
Flags: review?(bkelly)
Comment 8•8 years ago
|
||
Comment on attachment 8700932 [details] [diff] [review] Patch. Review of attachment 8700932 [details] [diff] [review]: ----------------------------------------------------------------- Sorry, I'm buried trying to get a beta crasher fixed before going on holiday. Andrea, can you take this review? ::: dom/workers/test/serviceworkers/app3/sw.js @@ +1,1 @@ > +// Useless service worker. Please use: dom/workers/test/serviceworkers/empty.js
Attachment #8700932 -
Flags: review?(bkelly) → review?(amarchesini)
Updated•8 years ago
|
Attachment #8700932 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 9•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d76b3c273046
Assignee | ||
Comment 10•8 years ago
|
||
use empty.js
Attachment #8700932 -
Attachment is obsolete: true
Attachment #8704550 -
Flags: review+
Assignee | ||
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/b53aa421ca199c5bf3504b74c0b80af06a69e8b9 Bug 1233644 - use pattern matching when listening clear-origin-data. r=baku
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b53aa421ca19
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•