1233862 - Implement a WeakCache wrapper type to cause a thing to be swept automatically every GC

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: impl_WeakCache-v0.diff

This is like WeakRef, but for things that are part of the runtime environment rather than discovered via tracing.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8700200 [details] [diff] [review]
impl_WeakCache-v0.diff

Review of attachment 8700200 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, this slipped through the cracks.

::: js/src/jsapi-tests/testGCWeakCache.cpp
@@ +39,5 @@
> +    CHECK(cache.has(tenured2));
> +    CHECK(cache.has(nursery1));
> +    CHECK(cache.has(nursery2));
> +
> +    // Since this relies on the UID map, we cannot check the non-existance

*nonexistence

@@ +40,5 @@
> +    CHECK(cache.has(nursery1));
> +    CHECK(cache.has(nursery2));
> +
> +    // Since this relies on the UID map, we cannot check the non-existance
> +    // of a pointer in the map -- see below for that.

You don't want to do it via CHECK(cache.count() == 2)?

Comment 2

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a19e246b0470

Comment 3

[Terrence Cole [:terrence]]

Attachment: impl_WeakCache-v1.diff

Rebased to use the new Policy stuff. Quite a bit cleaner now. Certainly cleaner to use. I'm going to carry the r+.

Comment 4

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b1bee876d26

Comment 5

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58c36d9ae2af72144b7dd995b4f2344f543c0f7d
Bug 1233862 - Add a WeakCache builtin to automatically manage sweeping; r=sfink

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/58c36d9ae2af