Closed Bug 1234095 Opened 8 years ago Closed 8 years ago

Rework animation sorting to support script-generated animations

Categories

(Core :: DOM: Animation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

Attachments

(1 file, 1 obsolete file)

This involves:

* Reworking CSSAnimation::HasLowerCompositeOrderThan to support generic animations[1]
* Reworking Animation::HasLowerCompositeOrderThan to handle the case when aOther provides some other sort of prioritization.

[1] https://dxr.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434/layout/style/nsAnimationManager.cpp#134
Here's an initial attempt at this. I don't really like that Animation needs knowledge of CSSTransition and CSSAnimation, but I think it's better than the previous arrangement at least.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Attachment #8707259 - Attachment is obsolete: true
Comment on attachment 8707333 [details] [diff] [review]
Rework sorting to handle to script-generated animations

Thanks for all the reviews lately. I'll try to make this the last one for this week!
Attachment #8707333 - Flags: review?(cam)
Attachment #8707333 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/ce9161cb9392
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: