Closed Bug 1234118 Opened 8 years ago Closed 8 years ago

Clean up code for handling 'do-command' and 'copypaste-docommand'

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(1 file)

In BrowserElementChildPreload.js and BrowserElementParent.js, we add code to support 'copypaste-docommand' and 'do-command' to handle to copy/paste/cut operation from text_selection_dialog.js in Gaia. We need to clean it up since SelectionCarets and text_selection_dialog.js are removed in bug 1221459 and bug 1221462.

Also the test case at [1] might need to be revised.

[1] https://dxr.mozilla.org/mozilla-central/rev/388bdc46ba51ee31da8b8abe977e0ca38d117434/dom/browser-element/mochitest/browserElement_CopyPaste.js#92
Assignee: nobody → tlin
Comment on attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug

https://reviewboard.mozilla.org/r/29021/#review25839
Attachment #8701671 - Flags: review?(mtseng) → review+
Comment on attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29021/diff/1-2/
Attachment #8701671 - Flags: review?(bugs)
Comment on attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug

https://reviewboard.mozilla.org/r/29021/#review25915

Odd code. I wonder why we had two almost the same notifications and message types.
Attachment #8701671 - Flags: review?(bugs) → review+
Thank you for the review! That's why wee need to delete the obsolete code to avoid confusion :)
Comment on attachment 8701671 [details]
MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29021/diff/1-2/
Attachment #8701671 - Attachment description: MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand' → MozReview Request: Bug 1234118 - Delete code for supporting 'do-command' and 'copypaste-docommand'. r=mtseng, r=smaug
Latest try (B2G ICS Emulator green!)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=29a34873a6d4
Flags: needinfo?(tlin)
https://hg.mozilla.org/mozilla-central/rev/5b36dc383731
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: